Opened 8 years ago
Closed 7 years ago
#15138 closed defect (fixed)
BuiltinFunction._is_registered is giving false negatives
Reported by:  ohanar  Owned by:  

Priority:  major  Milestone:  sage6.2 
Component:  symbolics  Keywords:  
Cc:  Merged in:  
Authors:  R. Andrew Ohana  Reviewers:  Ralf Stephan 
Report Upstream:  N/A  Work issues:  
Branch:  4c04c34 (Commits, GitHub, GitLab)  Commit:  4c04c344e42858e0722b19bc9cc83a265b1a9a61 
Dependencies:  Stopgaps: 
Description
This is easily encountered by the following:
sage: loads(dumps(sin)) == sin # derives from GinacFunction True sage: loads(dumps(cot)) == cot # should also be True False
Change History (6)
comment:1 Changed 8 years ago by
 Cc burcin added
comment:2 Changed 8 years ago by
 Cc burcin removed
comment:3 Changed 7 years ago by
 Milestone changed from sage6.1 to sage6.2
comment:4 Changed 7 years ago by
 Status changed from new to needs_review
comment:5 Changed 7 years ago by
 Branch set to u/rws/ticket/15138
 Commit set to 4c04c344e42858e0722b19bc9cc83a265b1a9a61
 Reviewers set to Ralf Stephan
 Status changed from needs_review to positive_review
Cannot see any problems, long tests fine in symbolic. I adapted the patch to newer code, added a doctest for this.
New commits:
4c04c34  Trac #15138: reviewer's patch: adapt to new code, add doctest

comment:6 Changed 7 years ago by
 Branch changed from u/rws/ticket/15138 to 4c04c344e42858e0722b19bc9cc83a265b1a9a61
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
The following seems to fix the issue:
I don't know the code, so I don't know what other implications this change might have (I didn't run the test suite).