Opened 9 years ago
Closed 9 years ago
#15124 closed enhancement (fixed)
Make pari_sig_on() macros accessible
| Reported by: | jdemeyer | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | sage-5.12 |
| Component: | c_lib | Keywords: | |
| Cc: | Merged in: | sage-5.12.beta5 | |
| Authors: | Jeroen Demeyer | Reviewers: | Peter Bruin |
| Report Upstream: | N/A | Work issues: | |
| Branch: | Commit: | ||
| Dependencies: | Stopgaps: |
GitHub link to the corresponding issue
Description (last modified by )
Up to now, the functions sig_on() and friends were redefined as _pari_sig_on() for use in sage/libs/pari.pyx. This is a hack and should be fixed by providing (and exporting) proper pari_sig_on() macros.
This ticket doesn't claim to fix all problems with PARI error handling, but at least it should improve the situation.
Also fix #10126.
Attachments (1)
Change History (11)
comment:1 Changed 9 years ago by
| Description: | modified (diff) |
|---|
comment:2 Changed 9 years ago by
| Description: | modified (diff) |
|---|
comment:3 Changed 9 years ago by
| Status: | new → needs_review |
|---|
comment:4 follow-up: 5 Changed 9 years ago by
| Cc: | pbruin removed |
|---|---|
| Reviewers: | → Peter Bruin |
comment:5 follow-up: 6 Changed 9 years ago by
Replying to pbruin:
This looks good to me. I was just thinking about this and had a very similar patch in mind (but with different names than
pari_sig_on()/pari_sig_off(), which I still find slightly misleading).
Would pari_catch_sig_on(), pari_catch_sig_off() be a good compromise?
comment:6 Changed 9 years ago by
Replying to jdemeyer:
Would
pari_catch_sig_on(),pari_catch_sig_off()be a good compromise?
Yes, I think that is a very good solution. A bit longer, but more descriptive.
Changed 9 years ago by
| Attachment: | 15124_pari_sig_on.patch added |
|---|
comment:8 Changed 9 years ago by
| Authors: | → Jeroen Demeyer |
|---|
comment:10 Changed 9 years ago by
| Merged in: | → sage-5.12.beta5 |
|---|---|
| Resolution: | → fixed |
| Status: | positive_review → closed |
This looks good to me. I was just thinking about this and had a very similar patch in mind (but with different names than
pari_sig_on()/pari_sig_off(), which I still find slightly misleading).I will run doctests and then give this a positive review - conditional on passing the tests of course, but not on the names for the macros. 8-)