Opened 8 years ago

Closed 8 years ago

#15124 closed enhancement (fixed)

Make pari_sig_on() macros accessible

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-5.12
Component: c_lib Keywords:
Cc: Merged in: sage-5.12.beta5
Authors: Jeroen Demeyer Reviewers: Peter Bruin
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

Up to now, the functions sig_on() and friends were redefined as _pari_sig_on() for use in sage/libs/pari.pyx. This is a hack and should be fixed by providing (and exporting) proper pari_sig_on() macros.

This ticket doesn't claim to fix all problems with PARI error handling, but at least it should improve the situation.

Also fix #10126.

Attachments (1)

15124_pari_sig_on.patch (105.4 KB) - added by jdemeyer 8 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 8 years ago by jdemeyer

  • Description modified (diff)

comment:2 Changed 8 years ago by jdemeyer

  • Description modified (diff)

comment:3 Changed 8 years ago by jdemeyer

  • Status changed from new to needs_review

comment:4 follow-up: Changed 8 years ago by pbruin

  • Cc pbruin removed
  • Reviewers set to Peter Bruin

This looks good to me. I was just thinking about this and had a very similar patch in mind (but with different names than pari_sig_on()/pari_sig_off(), which I still find slightly misleading).

I will run doctests and then give this a positive review - conditional on passing the tests of course, but not on the names for the macros. 8-)

comment:5 in reply to: ↑ 4 ; follow-up: Changed 8 years ago by jdemeyer

Replying to pbruin:

This looks good to me. I was just thinking about this and had a very similar patch in mind (but with different names than pari_sig_on()/pari_sig_off(), which I still find slightly misleading).

Would pari_catch_sig_on(), pari_catch_sig_off() be a good compromise?

comment:6 in reply to: ↑ 5 Changed 8 years ago by pbruin

Replying to jdemeyer:

Would pari_catch_sig_on(), pari_catch_sig_off() be a good compromise?

Yes, I think that is a very good solution. A bit longer, but more descriptive.

comment:7 Changed 8 years ago by jdemeyer

Name changed to pari_catch_sig_*

Changed 8 years ago by jdemeyer

comment:8 Changed 8 years ago by jdemeyer

  • Authors set to Jeroen Demeyer

comment:9 Changed 8 years ago by pbruin

  • Status changed from needs_review to positive_review

OK, all tests passed.

comment:10 Changed 8 years ago by jdemeyer

  • Merged in set to sage-5.12.beta5
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.