Opened 6 years ago

Closed 6 years ago

#15108 closed defect (fixed)

base extend for hyperelliptic curves

Reported by: mstreng Owned by:
Priority: major Milestone: sage-6.1
Component: geometry Keywords: base extend hyperelliptic curve sd53
Cc: jpflori Merged in:
Authors: Marco Streng Reviewers: Jean-Pierre Flori
Report Upstream: N/A Work issues:
Branch: u/jpflori/ticket/15108 (Commits) Commit:
Dependencies: Stopgaps:

Description (last modified by jpflori)

sage: R.<x> = QQ[]
sage: H = HyperellipticCurve(x^5+x+1)
sage: E = EllipticCurve([0,0,0,1,1])
sage: E.change_ring(RR)
Elliptic Curve defined by y^2 = x^3 + 1.00000000000000*x + 1.00000000000000 over Real Field with 53 bits of precision
sage: E.base_extend(RR)
Elliptic Curve defined by y^2 = x^3 + 1.00000000000000*x + 1.00000000000000 over Real Field with 53 bits of precision
sage: H.change_ring(RR)
Hyperelliptic Curve over Real Field with 53 bits of precision defined by y^2 = x^5 + x + 1.00000000000000
sage: H.base_extend(RR)
Closed subscheme of Projective Space of dimension 2 over Real Field with 53 bits of precision defined by:
  -x0^5 + x1^2*x2^3 - x0*x2^4 - x2^5

The last output should be a hyperelliptic curve object too.

Change History (11)

comment:1 Changed 6 years ago by mstreng

  • Authors set to Marco Streng
  • Description modified (diff)
  • Type changed from enhancement to defect

comment:2 Changed 6 years ago by mstreng

apply 15108.patch

comment:3 Changed 6 years ago by mstreng

This patch speeds up the count_points method for hyperelliptic curves over finite fields.

comment:4 Changed 6 years ago by mstreng

  • Status changed from new to needs_review

comment:5 Changed 6 years ago by jpflori

  • Cc jpflori added
  • Keywords sd53 added

comment:6 Changed 6 years ago by jpflori

  • Branch set to u/jpflori/15108
  • Description modified (diff)
  • Milestone changed from sage-5.12 to sage-5.13
  • Reviewers set to Jean-Pierre Flori
  • Status changed from needs_review to positive_review

Looks fine to me. I made the trivial rebase against the latest beta.

comment:7 Changed 6 years ago by jpflori

  • Branch changed from u/jpflori/15108 to u/jpflori/ticket/15108

comment:8 Changed 6 years ago by jdemeyer

Please make it clear whether the patch should be applied or the branch merged (in the latter case, move the milestone to sage-6.0)

comment:9 Changed 6 years ago by jpflori

  • Milestone changed from sage-5.13 to sage-6.0

Merge the branch.

comment:10 Changed 6 years ago by vbraun_spam

  • Milestone changed from sage-6.0 to sage-6.1

comment:11 Changed 6 years ago by vbraun

  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.