Opened 6 years ago

Closed 6 years ago

#15098 closed enhancement (fixed)

remove import of is_* in matrix.all

Reported by: chapoton Owned by:
Priority: major Milestone: sage-5.13
Component: linear algebra Keywords: deprecation cleanup
Cc: Merged in: sage-5.13.beta3
Authors: Frédéric Chapoton Reviewers: Darij Grinberg
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #15076 Stopgaps:

Attachments (2)

trac_15098_remove_global_is_in_matrix.patch (10.6 KB) - added by chapoton 6 years ago.
trac_15098_review-dg.patch (1.7 KB) - added by darij 6 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 6 years ago by chapoton

  • Authors set to Frédéric Chapoton
  • Component changed from PLEASE CHANGE to linear algebra
  • Status changed from new to needs_review
  • Type changed from PLEASE CHANGE to enhancement

comment:2 Changed 6 years ago by chapoton

  • Status changed from needs_review to needs_work

comment:3 Changed 6 years ago by chapoton

  • Status changed from needs_work to needs_review

Changed 6 years ago by chapoton

comment:4 Changed 6 years ago by darij

I'm not quite sure what would constitute a review of this. How can a change like this cause any bugs if the doctests don't fail?

Last edited 6 years ago by darij (previous) (diff)

comment:5 Changed 6 years ago by chapoton

Yes, indeed. So this should be an easy thing to review..

Changed 6 years ago by darij

comment:6 Changed 6 years ago by darij

  • Description modified (diff)
  • Reviewers set to Darij Grinberg

Great, this is done then. If you are OK with my changes, set this to positive_review.

for the patchbot:

apply trac_15098_remove_global_is_in_matrix.patch trac_15098_review-dg.patch​

comment:7 Changed 6 years ago by chapoton

  • Status changed from needs_review to positive_review

Thanks Darij !

I now set this to positive review.

comment:8 Changed 6 years ago by jdemeyer

  • Merged in set to sage-5.13.beta3
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.