[with patch, positive review] Allow text rotation in plotting

[was]

Since axes_label is broken in plot(), one must resort to adding your
own custom labels to a plot().

It would be nice in this application, and others, if one could rotate
text objects.  For example, it
would be nice to be able to make a custom y-axis label that was
parallel to the y-axis.  I guess,
in general, the ability to rotate text would be a useful feature.

For Sage, make sure to look up how Mathematica does text rotation, etc., and use that interface instead of making something up at random.

[mrtrumbe]

Regarding text rotation, can we just pass through the rotation option? This option is already available on the underlying matplotlib text objects, so it seems like a layup. I've attached a patch which accomplishes just that (it is a very minor change). This seems to work quite well here.

As for how Mathematica accomplishes it, take a look at their page: ​http://demonstrations.wolfram.com/HowTextRotationWorksInMathematica/

I think a solution like that would be pretty easy in sage. For example, this might work: a function which takes a text graphics primative and an angle and properly applies the rotation to the underlying matplotlib text object.

[wdj]

Replying to mrtrumbe:

Regarding text rotation, can we just pass through the rotation option? This option is already available on the underlying matplotlib text objects, so it seems like a layup. I've attached a patch which accomplishes just that (it is a very minor change). This seems to work quite well here.

I tried to download it and got a strange method. I guess it is not an hg patch but a diff?

Also, did you include an example in the docstring to illustrate your new feature?

[mrtrumbe]

Replying to wdj:

I tried to download it and got a strange method. I guess it is not an hg patch but a diff?

Also, did you include an example in the docstring to illustrate your new feature?

Sorry, I'm new to sage dev practices...is there documentation on generating a standard patch? I used diff to generate the attached patch.

I didn't include an example usage in the docstrings, but did include explanation of the feature. I'll update the docstring accordingly and update the patch.

[wdj]

Replying to mrtrumbe:

Replying to wdj:

I tried to download it and got a strange method. I guess it is not an hg patch but a diff?

Also, did you include an example in the docstring to illustrate your new feature?

Sorry, I'm new to sage dev practices...is there documentation on generating a standard patch? I used diff to generate the attached patch.

​http://www.sagemath.org/doc/developer/conventions.html and ​http://www.sagemath.org/doc/developer/producing_patches.html

I didn't include an example usage in the docstrings, but did include explanation of the feature. I'll update the docstring accordingly and update the patch.

Thanks.

[mrtrumbe]

Patch was premature. Accidental revert of other changes. Will fix shortly.

[mrtrumbe]

Ugh. Can't seem to delete patch files. Sorry for the clutter.

[mrtrumbe]

This is a proper hg patch. Code is docstring tested.

[kcrisman]

This is really neat, as the graphic says! It makes good sense to get more of the mpl functionality exposed, even if axes_labels now works again. Positive review. Apply only most recent patch.