Opened 6 years ago

Closed 6 years ago

#15058 closed defect (fixed)

Trigonometric and spike functions missing from the documentation

Reported by: eviatarbach Owned by:
Priority: critical Milestone: sage-5.12
Component: documentation Keywords:
Cc: kcrisman Merged in: sage-5.12.beta4
Authors: Eviatar Bach Reviewers: Karl-Dieter Crisman
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

sage/functions/trig.py and sage/functions/spike_function.py are missing from the documentation. It's particularly important to add the former.

Attachments (2)

trac15058.patch (2.5 KB) - added by eviatarbach 6 years ago.
trac_15058-review.patch (2.4 KB) - added by kcrisman 6 years ago.

Download all attachments as: .zip

Change History (9)

Changed 6 years ago by eviatarbach

comment:1 Changed 6 years ago by eviatarbach

  • Cc kcrisman added
  • Status changed from new to needs_review

Karl, I added you to CC since you wrote much of the spike_function documentation and I thought you might want to see it included in the built docs.

comment:2 Changed 6 years ago by kcrisman

Thanks, I'll try this and see how they look once I get beta1 built.

comment:3 Changed 6 years ago by kcrisman

Looks good. Friendly reviewer patch coming up, which I hope won't conflict with #10034 but if it does oh well...

Changed 6 years ago by kcrisman

comment:4 Changed 6 years ago by kcrisman

  • Authors set to Eviatar Bach
  • Reviewers set to Karl-Dieter Crisman
  • Status changed from needs_review to positive_review

comment:5 Changed 6 years ago by eviatarbach

Thanks! I don't see how it can conflict with #10034; maybe you meant another ticket?

comment:6 Changed 6 years ago by kcrisman

I didn't mean a substantive one, but possibly a trivial one (still needing rebasing), since it touches one of the same files (trig.py) near the place where that ticket changes things. I haven't actually checked this, probably it's not a problem.

Or, looking at it, I guess #10034 needs to have more files fixed. See my comment there.

comment:7 Changed 6 years ago by jdemeyer

  • Merged in set to sage-5.12.beta4
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.