Opened 7 years ago
Closed 7 years ago
#15055 closed enhancement (fixed)
minor cleanup in incidence structures
Reported by: | chapoton | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | sage-6.1 |
Component: | combinatorics | Keywords: | incidence |
Cc: | ncohen | Merged in: | |
Authors: | Frédéric Chapoton | Reviewers: | Nathann Cohen |
Report Upstream: | N/A | Work issues: | |
Branch: | u/chapoton/trac15055 | Commit: | |
Dependencies: | Stopgaps: |
Description
this ticket aims to
- remove unused import statements in the file combinat/designs/incidence_structures.py
- put this file in a pep8 standard shape
Change History (7)
comment:1 Changed 7 years ago by
- Branch set to u/chapoton/trac15055
comment:2 Changed 7 years ago by
- Cc ncohen added
- Status changed from new to needs_review
comment:3 Changed 7 years ago by
- Reviewers set to Nathann Cohen
Helloooo !!
Well, your patch looks good but your branch contains two commits, the second just fixing a typo. I think that it does not change anything, for if I got everything right your two commits will appear as only one when your patch will be merged into Sage.
This being said, it is very easy to merge (=squash) commits with git, so if you want to give it a try here's how it works : http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html
And you can decide whether you want to merge these two commits together, and set this ticket to positive_review
on my behalf when you are set :-)
Nathann
comment:4 Changed 7 years ago by
- Status changed from needs_review to positive_review
well, thanks for the info about merging commits.
I think I prefer to avoid doing that right now (if this is not needed), but I will try at some other occasion.
So, positive review
comment:5 Changed 7 years ago by
- Milestone changed from sage-5.12 to sage-6.0
comment:6 Changed 7 years ago by
- Milestone changed from sage-6.0 to sage-6.1
comment:7 Changed 7 years ago by
- Resolution set to fixed
- Status changed from positive_review to closed
I am trying the git way of life. Seems to work. Hope I have made everything right.