Opened 7 years ago
Closed 7 years ago
#15054 closed enhancement (fixed)
Some snarks graph constructors
Reported by:  ncohen  Owned by:  

Priority:  major  Milestone:  sage6.1 
Component:  graph theory  Keywords:  
Cc:  Merged in:  
Authors:  Nathann Cohen  Reviewers:  Frédéric Chapoton 
Report Upstream:  N/A  Work issues:  
Branch:  u/ncohen/15054 (Commits)  Commit:  0a4240c84ab1575c8d4ac80cdebddc5442c9b943 
Dependencies:  #15049  Stopgaps: 
Description (last modified by )
Some snarks missing from #9136.
 Tietze Snark : http://en.wikipedia.org/wiki/Tietze's_graph
 Szekeres Snarks : http://en.wikipedia.org/wiki/Szekeres_snark
 Watkins Snark : http://en.wikipedia.org/wiki/Watkins_snark
 Blanusa Snarks : http://en.wikipedia.org/wiki/Blanusa_snarks
Change History (15)
comment:1 Changed 7 years ago by
 Branch set to u/ncohen/15054
 Status changed from new to needs_review
comment:2 Changed 7 years ago by
 Description modified (diff)
comment:3 Changed 7 years ago by
 Milestone changed from sage5.12 to sage6.0
comment:4 Changed 7 years ago by
comment:5 Changed 7 years ago by
Fixed !
Nathann
comment:6 Changed 7 years ago by
 Commit set to cad106564ac8eaf3fad6a26c9ddf89a8fa5c157a
Branch pushed to git repo; I updated commit sha1. New commits:
[changeset:cad1065]  Fixing a stupid mistake 
[changeset:02793dd]  Blanusa Snarks graph constructors 
[changeset:717514f]  Watkins Snark graph constructor 
[changeset:a63227d]  Szekeres Snark Graph constructor 
[changeset:ad10f37]  Tietze Graph constructor 
[changeset:6ad238b]  Two broken links in the documentation of graph generators 
[changeset:4106e86]  WienerAraya Graph constructor 
[changeset:c2241b4]  Tutte Graph constructor 
[changeset:75a24f5]  Poussin Graph constructor 
[changeset:1a6d011]  Sousselier Graph constructor 
[changeset:67bdc54]  Markström Graph constructor 
[changeset:60cec2d]  Kittell Graph constructor 
[changeset:7a634da]  Horton Graph constructor 
[changeset:cc9d0c3]  Merge branch 'start' into meredith 
[changeset:ac53c3d]  Meredith Graph constructor 
comment:7 Changed 7 years ago by
 Commit changed from cad106564ac8eaf3fad6a26c9ddf89a8fa5c157a to c75aeda60c6722c7371cc07dec3c5478549dc746
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
[changeset:c75aeda]  Fixing a stupid mistake 
[changeset:63d241d]  Blanusa Snarks graph constructors 
[changeset:72fe3a8]  Watkins Snark graph constructor 
[changeset:dc00a5f]  Szekeres Snark Graph constructor 
[changeset:f688702]  Tietze Graph constructor 
[changeset:3025cca]  Two broken links in the documentation of graph generators 
[changeset:80ee647]  WienerAraya Graph constructor 
[changeset:706c06f]  Tutte Graph constructor 
[changeset:686d776]  Poussin Graph constructor 
[changeset:a42ac15]  Sousselier Graph constructor 
comment:8 Changed 7 years ago by
 Milestone changed from sage6.0 to sage6.1
comment:9 Changed 7 years ago by
Looks good to me. Maybe you could add two seealso between the two Blanusa snarks (so that one can find the other if one reads the doc of one) ?
Otherwise, you can set a positive review.
comment:10 Changed 7 years ago by
 Commit changed from c75aeda60c6722c7371cc07dec3c5478549dc746 to 0a4240c84ab1575c8d4ac80cdebddc5442c9b943
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
0a4240c  trac #15054: reviewer's comments

b622f3d  trac #15054: rebase on 6.1.beta0

3735dfd  Updated Sage version to 6.1.beta0

47c9c75  Trac #15224: Iterate over the points of a toric variety

f382aec  Trac #15403: knapsack's docstring doesn't document an useful feature

0c95d3d  Trac #15228: Default embedding of Ljubljana graph (typo)

09fd00b  Trac #12217: Finite field polynomials allow division by zero

9acb905  Trac 12217: correctly handle division by zero

8094791  Trac #14912: UniqueRepresentation tutorial could use more love

4ce6a49  Trac #15442: MILP solver CBC : undefined symbol: dgetrf_

comment:11 Changed 7 years ago by
Hmmmmmmmmm O_o
I just rebased this ticket on #15054 and added a patch for your comments (plus two broken links I found). All the other patches you see are just what got merged in beta0 O_o
Needs review again ^^;
Nathann
comment:12 Changed 7 years ago by
If you just want to see what is contained in this branch (whose last commit is 0a4240c) without seeing what is included in beta0 (whose commit is 3735dfd) you can do
git log 0a4240c ^3735dfd oneline
If you also want to ignore what was contained in the dependency #15049 (whose last commit was 3025cca) you can do
~/sage$ git log 0a4240c ^3735dfd ^3025cca oneline 0a4240c trac #15054: reviewer's comments b622f3d trac #15054: rebase on 6.1.beta0 c75aeda Fixing a stupid mistake 63d241d Blanusa Snarks graph constructors 72fe3a8 Watkins Snark graph constructor dc00a5f Szekeres Snark Graph constructor f688702 Tietze Graph constructor
Hoping that it helps ^^;
Nathann
comment:13 Changed 7 years ago by
 Reviewers set to Frédéric Chapoton
 Status changed from needs_review to positive_review
ok, good to go
comment:14 Changed 7 years ago by
Thaaaaaaaaaaanks !
Nathann
comment:15 Changed 7 years ago by
 Resolution set to fixed
 Status changed from positive_review to closed
the name of the Watkins graph is not correct