Opened 5 years ago

Closed 5 years ago

#15049 closed enhancement (fixed)

Some topological graph constructors

Reported by: ncohen Owned by:
Priority: major Milestone: sage-6.1
Component: graph theory Keywords:
Cc: Merged in:
Authors: Nathann Cohen Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: u/ncohen/15049 (Commits) Commit: 3025ccaaf3bb5ffef92298d4d9fc175287cd9d61
Dependencies: #15044 Stopgaps:

Description (last modified by ncohen)

Some graphs which were missing in #9136. And I don't want to miss another occasion to say that I hate topological graphs. Theirs embeddings are the ugliest things on earth. Nobody should study topological graphs. It has to be bad for karma.

Anyway... And we are almost done with the graphs from #9136 (short of Tutte's fragment, which I doubt to be of any use independent from Tutte's graph which this patch implements). Another patch on Snarks will follow, today or tomorrow.

Nathann

Change History (20)

comment:1 Changed 5 years ago by ncohen

  • Branch set to u/ncohen/15049
  • Status changed from new to needs_review

comment:2 Changed 5 years ago by ncohen

  • Description modified (diff)

comment:3 Changed 5 years ago by ncohen

  • Milestone changed from sage-5.12 to sage-6.0

comment:4 Changed 5 years ago by chapoton

there are some problems in the web links in

  • Horton
  • Markstrom
  • Sousellier

By the way, it seems that we do not have a is_hypohamiltonian method yet.

comment:5 Changed 5 years ago by ncohen

I just updated the branch by merging the patch with 5.12.beta1, though the link toward the Markstrom graph was okay on my side O_o

Nathann

comment:6 Changed 5 years ago by ncohen

Oh, and ... yeah, we don't have a is_hypohamiltonian method yet, but as the only way I know to code it is to call is_hamiltonian n+1 times, I'm not that eager to write it unless I really need it for small instances :-P

Nathann

comment:7 Changed 5 years ago by chapoton

for markstrom, the link is ok, but I have tried to see the doc in the notebook, and it was wrongly formatted

comment:8 Changed 5 years ago by ncohen

HMmmmmm... The.... Ahem. Notebook.... Does not run anymore on my version of Sage O_o

Nathann

comment:9 Changed 5 years ago by chapoton

there is the same kind of problem in the notebook with

graphs.GrotzschGraph??

(namely the doc is not shown in a formatted way)

I suspect that the ö of Grötsch and of Markström may be involved.

comment:10 Changed 5 years ago by ncohen

Hmmmmm... I can't run the notebook on my git version of Sage, and my mercurial version of Sage works fine with the Grotsch graph.

This being said, if it comes from weird accents I guess that it counts as a notebook bug. Could you try writing a function in the notebook which uses a weird accent, and get its documentation next to see if it works ?

Nathann

comment:11 Changed 5 years ago by chapoton

indeed, this happens also with the function

def pomme(x):
    """
    return the famous function pömme (`See there <http://www.pomme.com/>`_)
    
    EXAMPLES::
        
        sage: pomme(4)
        5
    """
    return x+1

and it works when replacing the ö by o. Should I open a ticket ?

comment:12 Changed 5 years ago by chapoton

there is a typo "Wikpedia" in Sousselier doc

comment:13 Changed 5 years ago by ncohen

Updated ! And yep, I think you should open a ticket but I have no idea where.. I don't even think that the notebook is actually part of Sage O_o

Nathann

P.S. : I rewrote the last commit, I did not add a new one.

comment:14 Changed 5 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, good enough for me.

comment:15 Changed 5 years ago by git

  • Commit set to 6ad238b9de481c202c1acdb9703b7a9aa65e67b9
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

[changeset:6ad238b]Two broken links in the documentation of graph generators
[changeset:4106e86]Wiener-Araya Graph constructor
[changeset:c2241b4]Tutte Graph constructor
[changeset:75a24f5]Poussin Graph constructor
[changeset:1a6d011]Sousselier Graph constructor
[changeset:67bdc54]Markström Graph constructor
[changeset:60cec2d]Kittell Graph constructor
[changeset:7a634da]Horton Graph constructor
[changeset:cc9d0c3]Merge branch 'start' into meredith
[changeset:ac53c3d]Meredith Graph constructor

comment:16 Changed 5 years ago by ncohen

I just rebased it... I hope it was effective :-/

Nathann

comment:17 Changed 5 years ago by git

  • Commit changed from 6ad238b9de481c202c1acdb9703b7a9aa65e67b9 to 3025ccaaf3bb5ffef92298d4d9fc175287cd9d61

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

[changeset:3025cca]Two broken links in the documentation of graph generators
[changeset:80ee647]Wiener-Araya Graph constructor
[changeset:706c06f]Tutte Graph constructor
[changeset:686d776]Poussin Graph constructor
[changeset:a42ac15]Sousselier Graph constructor
[changeset:4ed1802]Markström Graph constructor
[changeset:d63d5a2]Kittell Graph constructor
[changeset:3a63295]Horton Graph constructor
[changeset:d66b7d1]Meredith Graph constructor
[changeset:3b15578]Merging Sage-5.12.beta5, newest dev scripts, and the doctest fixes.

comment:18 Changed 5 years ago by chapoton

  • Status changed from needs_review to positive_review

ok, let me say "good to go" again..

comment:19 Changed 5 years ago by vbraun_spam

  • Milestone changed from sage-6.0 to sage-6.1

comment:20 Changed 5 years ago by vbraun

  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.