Changes between Initial Version and Version 6 of Ticket #15029


Ignore:
Timestamp:
09/09/13 16:05:31 (6 years ago)
Author:
tscrim
Comment:

Hey Amri,

Here's a review patch which does a few things:

  • Changes the name of the functions *2 to *_length_two to be a little more explicit.
  • Adds INPUT: blocks to some of the functions.
  • Fixes some docstring mistakes I didn't catch the first time around in the whole file. I also converted it to use Sage's macro for finite fields \GF{q}.

If you're happy with my changes, go ahead and set this to positive review.

Thanks for your work on this,
Travis

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #15029

    • Property Cc sage-combinat tscrim added
    • Property Reviewers changed from to Travis Scrimshaw
    • Property Dependencies changed from to #14907
    • Property Status changed from new to needs_review
  • Ticket #15029 – Description

    initial v6  
    11In the paper Similarity of matrices over local rings of length two [http://arxiv.org/abs/1212.6157], the similarity classes of n x n matrices with entries in a principal ideal local ring of length two are computed for n = 2, 3, 4. These calculations are being implemented in sage.
     2
     3Apply:
     4
     5* [attachment:trac_15029-additions-similarity_class_type-ap.patch]
     6* [attachment:trac_15029-review-ts.patch]