Opened 6 years ago

Closed 6 years ago

#15028 closed enhancement (fixed)

More named finitely presented groups

Reported by: dshurbert Owned by:
Priority: minor Milestone: sage-5.13
Component: group theory Keywords: group presentations, free groups, finitely presented groups
Cc: rbeezer, vbraun, mmarco Merged in: sage-5.13.beta2
Authors: Davis Shurbert Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #14791, #14913, #14813 Stopgaps:

Description (last modified by tscrim)

Add more groups accessible through groups.presentation. tab completion. This patch finishes off all named groups of order 15 or less, but not all groups associated with a universal name are implemented. The goal of this functionality is to make group presentations a topic more accessible to undergraduate students.

Depends on #14813 and #14791 for the named finitely presented groups infrastructure, and #14913 for computations with fp groups.

Apply

Attachments (2)

trac_15028_more_named_fpgroups.2.patch (8.3 KB) - added by dshurbert 6 years ago.
Replacement patch
trac_15028_more_named_fpgroups.patch (8.3 KB) - added by dshurbert 6 years ago.
Replacement patch

Download all attachments as: .zip

Change History (12)

comment:1 Changed 6 years ago by dshurbert

  • Status changed from new to needs_review

comment:2 Changed 6 years ago by dshurbert

  • Status changed from needs_review to needs_work

Rebasing to review patch on #14791

comment:3 Changed 6 years ago by dshurbert

  • Status changed from needs_work to needs_review

Rebased to review patch on #14791

comment:4 Changed 6 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

It doesn't seem like you're using wrap_FpGroup, so could you remove that from the imports? Looks good to me otherwise. Thanks.

Changed 6 years ago by dshurbert

Replacement patch

Changed 6 years ago by dshurbert

Replacement patch

comment:5 Changed 6 years ago by dshurbert

  • Description modified (diff)

Just removed unnecessary import, ignore the stray attachment. Thanks for the catch,

Davis

comment:6 Changed 6 years ago by tscrim

  • Description modified (diff)
  • Status changed from needs_review to positive_review

Thank you for your work on this.

Best,
Travis

For patchbot:

Apply: trac_15028_more_named_fpgroups.patch

comment:7 Changed 6 years ago by dshurbert

The work was fun, thanks for the reviews!

comment:8 Changed 6 years ago by tscrim

  • Milestone set to sage-5.12

comment:9 Changed 6 years ago by jdemeyer

  • Milestone changed from sage-5.12 to sage-5.13

comment:10 Changed 6 years ago by jdemeyer

  • Merged in set to sage-5.13.beta2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.