#15017 closed enhancement (fixed)
Symbolic spherical harmonic
| Reported by: | eviatarbach | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | sage-6.3 |
| Component: | symbolics | Keywords: | |
| Cc: | burcin, kcrisman | Merged in: | |
| Authors: | Eviatar Bach | Reviewers: | Jan Keitel, Travis Scrimshaw |
| Report Upstream: | N/A | Work issues: | |
| Branch: | 8588d16 (Commits) | Commit: | |
| Dependencies: | Stopgaps: |
Description
This ticket is for making spherical_harmonic a symbolic function.
Attachments (2)
Change History (20)
Changed 4 years ago by
comment:1 Changed 4 years ago by
- Cc burcin added
- Status changed from new to needs_review
Changed 4 years ago by
comment:2 Changed 4 years ago by
New patch gets coverage to 100% and fixes an issue in _eval_.
Patchbot apply trac15017_2.patch
comment:3 Changed 4 years ago by
- Cc kcrisman added
comment:4 Changed 4 years ago by
- Milestone changed from sage-6.1 to sage-6.2
comment:5 Changed 3 years ago by
- Milestone changed from sage-6.2 to sage-6.3
comment:6 Changed 3 years ago by
- Status changed from needs_review to needs_work
Patch does not merge.
comment:7 Changed 3 years ago by
- Branch set to u/jkeitel/15017
- Commit set to ee464ee19684ebdc9479caeecfba823cfbf6e4aa
- Status changed from needs_work to needs_review
New commits:
| ee464ee | Imported patch for making spherical harmonic symbolic.
|
comment:8 Changed 3 years ago by
I've imported the patch and made one tiny change in _evalf_ to fix a couple of doctests.
comment:9 Changed 3 years ago by
- Branch changed from u/jkeitel/15017 to public/ticket/spherical_harmonic-15017
- Commit changed from ee464ee19684ebdc9479caeecfba823cfbf6e4aa to 8588d165f9500afc62ae47374e10c62871ababb8
- Reviewers set to Jan Keitel, Travis Scrimshaw
comment:10 Changed 3 years ago by
Is 'Merzbacher' available online, so that we can do a real reference? Just wondering.
comment:11 Changed 3 years ago by
I think the citation was just copied from the Maxima documentation, which refers to Eugen Merzbacher Quantum Mechanics (2nd edition, 1970).
comment:12 Changed 3 years ago by
Frankly, I can't make sense of that. What is 9.64 supposed to refer it? Surely not equation 9.64 in http://instrumentation.tamu.edu/~ting/other/QM_Merzbacher.pdf
Should we just remove the reference?
comment:13 Changed 3 years ago by
Fine with me.
comment:14 Changed 3 years ago by
- Status changed from needs_review to positive_review
I gather this is now positive?
comment:15 follow-up: ↓ 18 Changed 3 years ago by
- Commit changed from 8588d165f9500afc62ae47374e10c62871ababb8 to 872e2bc0225b6929ed8cc052a63850c892abe723
- Status changed from positive_review to needs_review
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:
| 872e2bc | Remove old reference from spherical harmonics.
|
comment:16 Changed 3 years ago by
- Status changed from needs_review to positive_review
Well, now it is.
comment:17 Changed 3 years ago by
- Branch changed from public/ticket/spherical_harmonic-15017 to 872e2bc0225b6929ed8cc052a63850c892abe723
- Resolution set to fixed
- Status changed from positive_review to closed
comment:18 in reply to: ↑ 15 Changed 3 years ago by
- Branch changed from 872e2bc0225b6929ed8cc052a63850c892abe723 to 8588d165f9500afc62ae47374e10c62871ababb8
- Commit 872e2bc0225b6929ed8cc052a63850c892abe723 deleted
Replying to git:
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:
872e2bc Remove old reference from spherical harmonics.
This last commit has not been merged, see the discussion at sage-devel. I opened a new ticket for that commit: #18218.
Patchbot apply trac15017.patch