Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#15017 closed enhancement (fixed)

Symbolic spherical harmonic

Reported by: eviatarbach Owned by:
Priority: major Milestone: sage-6.3
Component: symbolics Keywords:
Cc: burcin, kcrisman Merged in:
Authors: Eviatar Bach Reviewers: Jan Keitel, Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 8588d16 (Commits) Commit:
Dependencies: Stopgaps:

Description

This ticket is for making spherical_harmonic a symbolic function.

Attachments (2)

trac15017.patch (4.7 KB) - added by eviatarbach 4 years ago.
trac15017_2.patch (6.4 KB) - added by eviatarbach 4 years ago.

Download all attachments as: .zip

Change History (20)

Changed 4 years ago by eviatarbach

comment:1 Changed 4 years ago by eviatarbach

  • Cc burcin added
  • Status changed from new to needs_review

Patchbot apply trac15017.patch

Changed 4 years ago by eviatarbach

comment:2 Changed 4 years ago by eviatarbach

New patch gets coverage to 100% and fixes an issue in _eval_.

Patchbot apply trac15017_2.patch

comment:3 Changed 4 years ago by kcrisman

  • Cc kcrisman added

comment:4 Changed 4 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:5 Changed 3 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:6 Changed 3 years ago by rws

  • Status changed from needs_review to needs_work

Patch does not merge.

comment:7 Changed 3 years ago by jkeitel

  • Branch set to u/jkeitel/15017
  • Commit set to ee464ee19684ebdc9479caeecfba823cfbf6e4aa
  • Status changed from needs_work to needs_review

New commits:

ee464eeImported patch for making spherical harmonic symbolic.

comment:8 Changed 3 years ago by jkeitel

I've imported the patch and made one tiny change in _evalf_ to fix a couple of doctests.

comment:9 Changed 3 years ago by tscrim

  • Authors set to Eviatar Bach
  • Branch changed from u/jkeitel/15017 to public/ticket/spherical_harmonic-15017
  • Commit changed from ee464ee19684ebdc9479caeecfba823cfbf6e4aa to 8588d165f9500afc62ae47374e10c62871ababb8
  • Reviewers set to Jan Keitel, Travis Scrimshaw

Some minor review tweaks from me, but if you're okay with them, then positive review.


New commits:

39565d2Merge branch 'u/jkeitel/15017' of trac.sagemath.org:sage into public/ticket/spherical_harmonic-15017
8588d16Minor review tweaks for spherical harmonic functions.

comment:10 Changed 3 years ago by kcrisman

Is 'Merzbacher' available online, so that we can do a real reference? Just wondering.

comment:11 Changed 3 years ago by eviatarbach

I think the citation was just copied from the Maxima documentation, which refers to Eugen Merzbacher Quantum Mechanics (2nd edition, 1970).

comment:12 Changed 3 years ago by jkeitel

Frankly, I can't make sense of that. What is 9.64 supposed to refer it? Surely not equation 9.64 in http://instrumentation.tamu.edu/~ting/other/QM_Merzbacher.pdf

Should we just remove the reference?

comment:13 Changed 3 years ago by eviatarbach

Fine with me.

comment:14 Changed 3 years ago by rws

  • Status changed from needs_review to positive_review

I gather this is now positive?

comment:15 follow-up: Changed 3 years ago by git

  • Commit changed from 8588d165f9500afc62ae47374e10c62871ababb8 to 872e2bc0225b6929ed8cc052a63850c892abe723
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

872e2bcRemove old reference from spherical harmonics.

comment:16 Changed 3 years ago by jkeitel

  • Status changed from needs_review to positive_review

Well, now it is.

comment:17 Changed 3 years ago by vbraun

  • Branch changed from public/ticket/spherical_harmonic-15017 to 872e2bc0225b6929ed8cc052a63850c892abe723
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:18 in reply to: ↑ 15 Changed 3 years ago by cheuberg

  • Branch changed from 872e2bc0225b6929ed8cc052a63850c892abe723 to 8588d165f9500afc62ae47374e10c62871ababb8
  • Commit 872e2bc0225b6929ed8cc052a63850c892abe723 deleted

Replying to git:

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

872e2bcRemove old reference from spherical harmonics.

This last commit has not been merged, see the discussion at sage-devel. I opened a new ticket for that commit: #18218.

Note: See TracTickets for help on using tickets.