Opened 8 years ago

Closed 2 years ago

#14988 closed enhancement (duplicate)

Add algorithms to calculate the conway mass of ternary quadratic forms

Reported by: gdrama Owned by:
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: quadratic forms Keywords:
Cc: Merged in:
Authors: Gustavo Rama Reviewers: Simon Brandhorst
Report Upstream: N/A Work issues:
Branch: public/ticket/14988 (Commits, GitHub, GitLab) Commit: 1e4eb53dadffdbc44ff52802bbb983e0c0c1f1db
Dependencies: Stopgaps:

Status badges

Description

Add algorithms to calculate the conway mass of ternary quadratic forms.

Attachments (1)

trac_14998-Conway_Mass.patch (22.5 KB) - added by gdrama 8 years ago.

Download all attachments as: .zip

Change History (24)

Changed 8 years ago by gdrama

comment:1 Changed 8 years ago by gdrama

  • Status changed from new to needs_review

comment:2 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:3 Changed 7 years ago by chapoton

  • Branch set to public/ticket/14988
  • Commit set to 31040e42d7b09e8111d89e8f43ef2d3eb5615c04

Here is a git branch


New commits:

31040e4#14988: Add algorithms to calculate the conway mass of ternary quadratic forms.

comment:4 Changed 7 years ago by git

  • Commit changed from 31040e42d7b09e8111d89e8f43ef2d3eb5615c04 to 2ef8c179f3b888dc81956982478826ade766d500

Branch pushed to git repo; I updated commit sha1. New commits:

2ef8c17trac #14988 cosmetic cleanup

comment:5 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:6 Changed 7 years ago by rws

  • Status changed from needs_review to needs_work

Merge conflict.

comment:7 Changed 7 years ago by git

  • Commit changed from 2ef8c179f3b888dc81956982478826ade766d500 to d31a3655e5c0345ba113a78ce87311b9e28ddd5b

Branch pushed to git repo; I updated commit sha1. New commits:

d31a365Merge branch 'public/ticket/14988' of ssh://trac.sagemath.org:22/sage into 14988

comment:8 Changed 7 years ago by chapoton

  • Status changed from needs_work to needs_review

comment:9 Changed 7 years ago by chapoton

  • Authors set to Gustavo Rama

comment:10 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:11 Changed 6 years ago by chapoton

  • Status changed from needs_review to needs_work

one doctest failing

comment:12 Changed 6 years ago by git

  • Commit changed from d31a3655e5c0345ba113a78ce87311b9e28ddd5b to 5301c62d0edd35b185381c8e23a875afab7e2f24

Branch pushed to git repo; I updated commit sha1. New commits:

f574129Merge branch 'public/ticket/14988' into 6.6.rc1
5301c62trac #14988 correct failing doctest

comment:13 Changed 6 years ago by chapoton

  • Status changed from needs_work to needs_review

comment:14 Changed 5 years ago by chapoton

  • Milestone changed from sage-6.4 to sage-6.10

comment:15 Changed 4 years ago by git

  • Commit changed from 5301c62d0edd35b185381c8e23a875afab7e2f24 to e4c8aa3ca6085a96868594ef0aec26570f97172e

Branch pushed to git repo; I updated commit sha1. New commits:

e4c8aa3Merge branch 'public/ticket/14988' in 7.5.b4

comment:16 Changed 3 years ago by git

  • Commit changed from e4c8aa3ca6085a96868594ef0aec26570f97172e to 04609765d2217fcc5f1ededc12101c100528bca2

Branch pushed to git repo; I updated commit sha1. New commits:

0460976Merge branch 'public/ticket/14988' in 8.2.rc0

comment:17 Changed 3 years ago by chapoton

  • Milestone changed from sage-6.10 to sage-8.3

comment:18 Changed 3 years ago by git

  • Commit changed from 04609765d2217fcc5f1ededc12101c100528bca2 to 4fa9ca02a51838700a6bfe89f168114c425d5886

Branch pushed to git repo; I updated commit sha1. New commits:

4fa9ca0Merge branch 'public/ticket/14988' in 8.3.b5

comment:19 Changed 3 years ago by git

  • Commit changed from 4fa9ca02a51838700a6bfe89f168114c425d5886 to 1e4eb53dadffdbc44ff52802bbb983e0c0c1f1db

Branch pushed to git repo; I updated commit sha1. New commits:

1e4eb53Merge branch 'public/ticket/14988' in 8.3.b8

comment:20 Changed 3 years ago by vdelecroix

  • Milestone changed from sage-8.3 to sage-8.4

update milestone 8.3 -> 8.4

comment:21 Changed 3 years ago by sbrandhorst

  • Reviewers set to Simon Brandhorst
  • Status changed from needs_review to needs_info

We already have a Conway mass for quadratic forms over ZZ. Can you give a reason why we need yet another implementation in a more restricted use case? It will be more demanding to sustain two implementations of the Conway mass.

comment:22 Changed 2 years ago by sbrandhorst

  • Milestone changed from sage-8.4 to sage-duplicate/invalid/wontfix
  • Status changed from needs_info to needs_review

I would close this.

comment:23 Changed 2 years ago by chapoton

  • Resolution set to duplicate
  • Status changed from needs_review to closed
Note: See TracTickets for help on using tickets.