Opened 6 years ago

Closed 6 years ago

#14985 closed defect (fixed)

Let zlib 1.2.8 build on Cygwin

Reported by: jpflori Owned by:
Priority: critical Milestone: sage-5.11
Component: packages: standard Keywords: cygwin zlib spkg
Cc: jdemeyer, tscrim Merged in: sage-5.11.rc1
Authors: Jean-Pierre Flori Reviewers: Travis Scrimshaw
Report Upstream: Not yet reported upstream; Will do shortly. Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by jpflori)

The update from 1.2.6 to 1.2.8 broke building on Cygwin because of calls to the gzopen_w function introduced in 1.2.7 and unavailable on Cygwin.

Use:

Attachments (2)

1.2.7-zlib-symbols.patch (250 bytes) - added by jpflori 6 years ago.
Cygwin's folk patch
zlib-1.2.8.p0.diff (918 bytes) - added by jpflori 6 years ago.
Spkg diff, for review only.

Download all attachments as: .zip

Change History (14)

comment:1 Changed 6 years ago by jpflori

comment:2 Changed 6 years ago by jpflori

See https://github.com/madler/zlib/issues/45 on upstream bugtracker.

comment:3 Changed 6 years ago by jpflori

  • Cc jdemeyer added
  • Report Upstream changed from N/A to Reported upstream. No feedback yet.

Maybe we could make this a blocker for 5.11? Note that different fixes are already proposed on the upstream bugtracker, so that crafting an spkg will not take ages.

I'm sorry I had no time to test the 5.10 rc's on Cygwin and let that go in... let's try to release a 5.11 version compilable on Cygwin(32)!

Changed 6 years ago by jpflori

Cygwin's folk patch

comment:4 Changed 6 years ago by jpflori

Such a patch prevents the definition of gzopen_w on Windows, but he, the Cygwin's folk does not care, and we don't support MSVC so, we can do just the same I guess.

Changed 6 years ago by jpflori

Spkg diff, for review only.

comment:5 Changed 6 years ago by jpflori

  • Authors set to Jean-Pierre Flori
  • Description modified (diff)
  • Keywords cygwin zlib spkg added
  • Priority changed from major to critical
  • Report Upstream changed from Reported upstream. No feedback yet. to Not yet reported upstream; Will do shortly.
  • Status changed from new to needs_review

I've upped a spkg using the same fix as Cygwin.

comment:6 Changed 6 years ago by jpflori

  • Description modified (diff)

comment:7 Changed 6 years ago by jpflori

  • Description modified (diff)

comment:8 Changed 6 years ago by jpflori

Cannot test on a real install till tomorrow...

comment:9 Changed 6 years ago by jpflori

  • Cc tscrim added

comment:10 Changed 6 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

It built for me both on cygwin 32 and 64.

comment:11 Changed 6 years ago by jdemeyer

  • Milestone changed from sage-5.12 to sage-5.11

comment:12 Changed 6 years ago by jdemeyer

  • Merged in set to sage-5.11.rc1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.