Opened 9 years ago

Closed 9 years ago

#14975 closed defect (fixed)

cmp() doctest failure in toric morphism

Reported by: jdemeyer Owned by:
Priority: blocker Milestone: sage-5.11
Component: algebraic geometry Keywords:
Cc: novoselt, vbraun Merged in: sage-5.11.rc0
Authors: Andrey Novoseltsev Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

The following can happen with #14353:

sage -t --long devel/sage/sage/schemes/toric/morphism.py
**********************************************************************
File "devel/sage/sage/schemes/toric/morphism.py", line 459, in sage.schemes.toric.morphism.SchemeMorphism_fan_toric_variety.__cmp__
Failed example:
    cmp(phi, phi.factor()[0])
Expected:
    -1
Got:
    1
**********************************************************************

Attachments (1)

trac_14975_cmp_in_toric_morphism.patch (686 bytes) - added by novoselt 9 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 9 years ago by novoselt

Working

Changed 9 years ago by novoselt

comment:2 Changed 9 years ago by novoselt

  • Authors set to Andrey Novoseltsev
  • Status changed from new to needs_review

Was hit by it before but apparently forgot...

comment:3 Changed 9 years ago by jdemeyer

  • Reviewers set to Jeroen Demeyer
  • Status changed from needs_review to positive_review

comment:4 Changed 9 years ago by jdemeyer

  • Merged in set to sage-5.11.rc0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.