Opened 7 years ago
Closed 7 years ago
#14968 closed defect (fixed)
Store actual tarball name in pkg metadata.
Reported by: | robertwb | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-6.0 |
Component: | build | Keywords: | |
Cc: | Merged in: | ||
Authors: | Robert Bradshaw | Reviewers: | Volker Braun |
Report Upstream: | N/A | Work issues: | |
Branch: | u/vbraun/ticket/14968 (Commits) | Commit: | b6b4adb3112a47b466b72d2a564dbe39985b1bf9 |
Dependencies: | Stopgaps: |
Description
See discussion at https://groups.google.com/forum/#!topic/sage-git/Qkjey5OhVAo
Change History (12)
comment:1 Changed 7 years ago by
- Branch set to u/robertwb/14968-tarballs
- Status changed from new to needs_review
comment:2 Changed 7 years ago by
comment:3 Changed 7 years ago by
Patch looks good to me.
I don't think we should allow an arbitrary URL. Then we also have to make sure that every Sage release all URLs actually point to our servers. And for development its much easier to just put your tarball into the /upstream
directory instead of uploading it to a remote server and then downloading it again. It it turns out to be a crucial feature we can always add it later.
comment:4 Changed 7 years ago by
- Reviewers set to Volker Braun
- Status changed from needs_review to positive_review
comment:5 Changed 7 years ago by
So, now that this is positively reviewed, when/where does it get merged?
comment:6 Changed 7 years ago by
- Branch changed from u/robertwb/14968-tarballs to u/robertwb/ticket/14968
- Created changed from 07/25/13 05:49:59 to 07/25/13 05:49:59
- Modified changed from 08/06/13 05:34:56 to 08/06/13 05:34:56
comment:7 Changed 7 years ago by
- Commit set to 19382e19fea8e664b8892867f6ac93beaaf4a01d
- Status changed from positive_review to needs_review
comment:8 Changed 7 years ago by
There were some merge conflicts. I've resolved those and improved the path a bit, please take another look (and hopefully merge before it goes stale again).
comment:9 Changed 7 years ago by
- Commit changed from 19382e19fea8e664b8892867f6ac93beaaf4a01d to f1ad358ed59abdb691b7de0ad40e61460e8b57d9
Branch pushed to git repo; I updated commit sha1. New commits:
f1ad358 | fix ppl tarball |
comment:11 Changed 7 years ago by
- Branch changed from u/robertwb/ticket/14968 to u/vbraun/ticket/14968
- Commit changed from f1ad358ed59abdb691b7de0ad40e61460e8b57d9 to b6b4adb3112a47b466b72d2a564dbe39985b1bf9
I fixed conflicts in r and git by merging with the newer version....
Last 10 new commits:
b6b4adb | updated git checksum |
a25d736 | updated R checksum |
326f347 | [FIXUP] 5.13.rc0: update git specific files |
c1cd99c | Merge branch 'upstream' into u/ohanar/build_system |
fbb6305 | 5.13 |
f6fcc98 | fixing git interface doctests for new git version |
4dd4da5 | Merge dev scripts branch since their doctests are changed by the new git |
f3df294 | update git to latest upstream version 1.8.4.4 |
946b5b4 | fix the commandline sage -dev script |
2941308 | Use a DoctestSageDevWrapper? for the global dev object during doctests |
comment:12 Changed 7 years ago by
- Resolution set to fixed
- Status changed from positive_review to closed
We could also support supporting a URL as the tarball field. That would be useful during development: people who cannot upload to the mirror network can then just put the upstream URL there. Actually, that might even make sense in general, not only during development.