Opened 10 years ago

Closed 10 years ago

#1494 closed defect (fixed)

[with patch, with positive review] bug coercing from maximal order of cyclotomic field into cyclotomic field

Reported by: was Owned by: somebody
Priority: major Milestone: sage-2.9
Component: basic arithmetic Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description 

sage: K.<z> = CyclotomicField(7)
sage: O = K.maximal_order()
sage: K(O.1)
Traceback (most recent call last):
...
TypeError: Cannot coerce element into this number field

Attachments (2)

trac-1494.patch​ (1.3 KB) - added by was 10 years ago.
trac-1494-fixdoctest.patch​ (767 bytes) - added by cwitty 10 years ago.

Download all attachments as: .zip

Change History (6)

Changed 10 years ago by was

comment:1 Changed 10 years ago by robertwb

I am wary of this patch, but will look into it more.

Changed 10 years ago by cwitty

comment:2 Changed 10 years ago by cwitty

  • Summary changed from bug coercing from maximal order of cyclotomic field into cyclotomic field to [with patch, with positive review] bug coercing from maximal order of cyclotomic field into cyclotomic field

Looks OK to me. The new doctest passes (after applying the trivial patch in trac-1494-fixdoctest.patch).

comment:3 Changed 10 years ago by robertwb

I was worried if there was some special reason we were calling _coerce_from_other_number_field here previously, but it looks OK.

This will probably be revised when coercion is flushed throughout the system anyways.

comment:4 Changed 10 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged in 2.9.rc0.

Note: See TracTickets for help on using tickets.