Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#14908 closed defect (duplicate)

Two small issues with make micro_release

Reported by: mmezzarobba Owned by:
Priority: minor Milestone: sage-duplicate/invalid/wontfix
Component: build Keywords:
Cc: Merged in:
Authors: Reviewers: Marc Mezzarobba, Volker Braun
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

A trivial patch to experiment with the git workflow...

  • the micro_release rule of the Makefile used |&, which is a bash4-ism
  • the filtering of error messages did not work in non-English locales

Change History (9)

comment:1 Changed 8 years ago by mmezzarobba

  • Status changed from new to needs_review

comment:2 follow-up: Changed 8 years ago by ohanar

  • Status changed from needs_review to needs_work

The working branch was a workaround until #14781 got resolved.

Please rebase against the build_system branch.

comment:3 in reply to: ↑ 2 Changed 8 years ago by mmezzarobba

  • Status changed from needs_work to needs_review

Replying to ohanar:

Please rebase against the build_system branch.

Done.

comment:4 Changed 8 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-6.0

comment:5 Changed 8 years ago by vbraun

  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

Looks good to me

comment:6 follow-up: Changed 8 years ago by ohanar

  • Milestone changed from sage-6.0 to sage-duplicate/invalid/wontfix

I've merged this into the build_system branch at #14480, so I'm marking this as a duplicate so that we can close this ticket now.

comment:7 in reply to: ↑ 6 Changed 8 years ago by mmezzarobba

  • Branch u/mmezzarobba/fix_micro_release deleted
  • Commit set to 0628ee3b65e6195df2195c98b1df4c3767fcaad9

Replying to ohanar:

I've merged this into the build_system branch at #14480, so I'm marking this as a duplicate so that we can close this ticket now.

Ok, so I've deleted the branch and filled in the Commit field instead.

comment:8 Changed 8 years ago by jdemeyer

  • Commit 0628ee3b65e6195df2195c98b1df4c3767fcaad9 deleted
  • Resolution set to duplicate
  • Status changed from positive_review to closed

comment:9 Changed 8 years ago by jdemeyer

  • Authors Marc Mezzarobba deleted
  • Reviewers changed from Volker Braun to Marc Mezzarobba, Volker Braun
Note: See TracTickets for help on using tickets.