Context Navigation

← Previous Ticket
Next Ticket →

#14907 closed enhancement (fixed)

Implement Similarity Class Types

Reported by:	amri	Owned by:	amri
Priority:	major	Milestone:	sage-5.12
Component:	combinatorics	Keywords:	similarity class type finite field
Cc:	sage-combinat, tscrim	Merged in:	sage-5.12.beta2
Authors:	Amritanshu Prasad	Reviewers:	Travis Scrimshaw
Report Upstream:	N/A	Work issues:
Branch:		Commit:
Dependencies:	#10630	Stopgaps:

Description (last modified by tscrim)

Implement similarity class types for square matrices with entries in a finite field.

Apply: trac_14907-similarity_classes-ap.patch

Attachments (2)

trac_14907-review-ts.patch (708 bytes) - added by tscrim 6 years ago.
trac_14907-similarity_classes-ap.patch (37.7 KB) - added by amri 6 years ago.

Download all attachments as: .zip

Change History (15)

comment:1 Changed 6 years ago by amri

Status changed from new to needs_review

comment:2 Changed 6 years ago by tscrim

Reviewers changed from tscrim to Travis Scrimshaw
Status changed from needs_review to positive_review

Looks good to me. Thanks.

comment:3 Changed 6 years ago by zabrocki

Does this patch have a dependency on #10630 and maybe something else? Something is wrong because I get errors. One of the tests from sage.combinat.matrix_type import primitives I get the error: ImportError: No module named matrix_type

I don't even know where to look for these. Can someone point me to the right patches and maybe how to even look this up myself?

Changed 6 years ago by tscrim

Attachment trac_14907-review-ts.patch added

comment:4 Changed 6 years ago by tscrim

I was working with Armi on this patch and we forgot to run sync-build after changing the name of the file (hence this was still there as a compiled file). Here's the small review patch which fixes this.