Opened 6 years ago
Closed 6 years ago
#14907 closed enhancement (fixed)
Implement Similarity Class Types
Reported by: | amri | Owned by: | amri |
---|---|---|---|
Priority: | major | Milestone: | sage-5.12 |
Component: | combinatorics | Keywords: | similarity class type finite field |
Cc: | sage-combinat, tscrim | Merged in: | sage-5.12.beta2 |
Authors: | Amritanshu Prasad | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | #10630 | Stopgaps: |
Description (last modified by )
Implement similarity class types for square matrices with entries in a finite field.
Attachments (2)
Change History (15)
comment:1 Changed 6 years ago by
- Status changed from new to needs_review
comment:2 Changed 6 years ago by
- Reviewers changed from tscrim to Travis Scrimshaw
- Status changed from needs_review to positive_review
comment:3 Changed 6 years ago by
Does this patch have a dependency on #10630 and maybe something else? Something is wrong because I get errors.
One of the tests from sage.combinat.matrix_type import primitives
I get the error:
ImportError: No module named matrix_type
I don't even know where to look for these. Can someone point me to the right patches and maybe how to even look this up myself?
Changed 6 years ago by
comment:4 Changed 6 years ago by
I was working with Armi on this patch and we forgot to run sync-build after changing the name of the file (hence this was still there as a compiled file). Here's the small review patch which fixes this.
comment:5 Changed 6 years ago by
- Dependencies set to #10630
And the dependency? I am right about this, right?
comment:6 Changed 6 years ago by
I don't think so...but it's better safe than sorry.
comment:7 Changed 6 years ago by
- Milestone changed from sage-5.11 to sage-5.12
comment:8 Changed 6 years ago by
- Status changed from positive_review to needs_work
I will be adding some new methods and functions which get used frequently with these classes.
Changed 6 years ago by
comment:9 Changed 6 years ago by
I think I am done with it for now.
comment:10 Changed 6 years ago by
- Status changed from needs_work to positive_review
Looks good to me. Thanks.
comment:11 Changed 6 years ago by
- Status changed from positive_review to needs_info
Please clarify which patches should be applied.
comment:12 Changed 6 years ago by
- Description modified (diff)
- Status changed from needs_info to positive_review
Forgot to add that. Sorry.
For patchbot:
Apply: trac_14907-similarity_classes-ap.patch
comment:13 Changed 6 years ago by
- Merged in set to sage-5.12.beta2
- Resolution set to fixed
- Status changed from positive_review to closed
Looks good to me. Thanks.