Opened 8 years ago

Closed 8 years ago

#14892 closed defect (fixed)

Track all files in cliquer, and minor cleanup

Reported by: vbraun Owned by: jdemeyer
Priority: major Milestone: sage-5.12
Component: packages: standard Keywords:
Cc: Merged in: sage-5.12.beta1
Authors: Volker Braun Reviewers: Nathann Cohen
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by vbraun)

Move untracked additions to the upstream sources to src/ as required for #14781

Spkg diff cliquer-p0-p1.diff

Attachments (2)

trac_14892_cliquer_cleanup.patch (2.0 KB) - added by vbraun 8 years ago.
Initial patch
cliquer-p0-p1.diff (6.8 KB) - added by vbraun 8 years ago.
Spkg diff for review purposes only

Download all attachments as: .zip

Change History (8)

Changed 8 years ago by vbraun

Initial patch

Changed 8 years ago by vbraun

Spkg diff for review purposes only

comment:1 Changed 8 years ago by vbraun

  • Authors set to Volker Braun
  • Description modified (diff)
  • Status changed from new to needs_review

comment:2 Changed 8 years ago by ncohen

  • Status changed from needs_review to positive_review

>_<

If we were japanese guys you would not have written such a patch, for it is shameful to me >_<

God. How did I write this thing in the first place ? Please forgive me >_<

Anyway, thank you very much ! This ADD_EDGE method looks useful indeed. And all tests pass, the sun shines and the birds sing outside.

Thaaaaaaaaaaaaaanks !

Nathann

comment:3 Changed 8 years ago by ncohen

  • Reviewers set to Nathann Cohen

comment:4 Changed 8 years ago by jdemeyer

Any reason why you use

for patch in `ls ../patches/*.patch`; do

instead of the standard

for patch in ../patches/*.patch; do

(both work correctly but the first wastes a process and will display a confusing error if no patch files are found)

Last edited 8 years ago by jdemeyer (previous) (diff)

comment:5 Changed 8 years ago by vbraun

I switched the loop to the other syntax, updated spkg at the same place.

comment:6 Changed 8 years ago by jdemeyer

  • Merged in set to sage-5.12.beta1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.