Opened 6 years ago
Closed 6 years ago
#14884 closed defect (fixed)
Multiplication by identity in tableau.py and tableau_tuple.py
Reported by: | darij | Owned by: | tbd |
---|---|---|---|
Priority: | minor | Milestone: | sage-5.12 |
Component: | combinatorics | Keywords: | combinat, tableau, tableau tuple |
Cc: | tscrim, sage-combinat | Merged in: | sage-5.12.beta5 |
Authors: | Darij Grinberg | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | #14101 | Stopgaps: |
Description
This is similar to #14883 in that it removes a multiplication of a permutation by the identity permutation. This time the multiplication was not useless (it was meant to coerce the permutation into a symmetric group of large enough size), but that is easier done by just concatenating lists (given that the result is only needed as a list). There is a minor speedup (577µs to 496µs on the one of the doctested examples), but the purpose of this patch is really to replace a hack by a more logical manipulation.
Travis, feel free to fold this into your patch if you wish.
Attachments (1)
Change History (8)
comment:1 Changed 6 years ago by
- Status changed from new to needs_review
comment:2 Changed 6 years ago by
- Cc sage-combinat added
- Component changed from PLEASE CHANGE to combinatorics
comment:3 Changed 6 years ago by
- Dependencies changed from 14101 to #14101
comment:4 Changed 6 years ago by
- Reviewers set to Travis Scrimshaw
comment:5 Changed 6 years ago by
Good point; fixed. Thanks for checking this.
comment:6 Changed 6 years ago by
- Status changed from needs_review to positive_review
Looks good to me. Thanks Darij.
comment:7 Changed 6 years ago by
- Merged in set to sage-5.12.beta5
- Resolution set to fixed
- Status changed from positive_review to closed
Hey Darij,
I believe taking the copy slice
w[:]
ofw
is unnecessary.Could you remove this and repost?
Thanks,
Travis