Opened 8 years ago

Closed 8 years ago

#14864 closed defect (duplicate)

descents composition of the empty permutation is wrong

Reported by: stumpc5 Owned by: sage-combinat
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: combinatorics Keywords: permutation, descent composition, FindStat
Cc: chrisjamesberg, VivianePons, tscrim, zabrocki Merged in:
Authors: Reviewers: Christian Stump
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #14808 Stopgaps:

Status badges

Description 

sage: Permutation([]).descents_composition()
[0]

Attachments (1)

trac_14864-descents_composition_of_empty_permutation-cs.patch​ (933 bytes) - added by stumpc5 8 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 8 years ago by stumpc5

  • Cc zabrocki added
  • Status changed from new to needs_review

comment:2 Changed 8 years ago by stumpc5

  • Keywords FindStat added

comment:3 Changed 8 years ago by zabrocki

Please change one thing and I can set to positive review. You write ...descent, see :trac:14864::... and I think it should read ...descent, see :trac:`14864`:...

comment:4 Changed 8 years ago by zabrocki

I was thinking about it and It is probably just easier to erase the reference since it is not like the trac ticket contains more information about why this should be the base case.

Changed 8 years ago by stumpc5

comment:5 Changed 8 years ago by stumpc5

Hi Mike, thanks for checking - I agree with your suggested change and updated the patch.

Cheers, Christian

comment:6 Changed 8 years ago by zabrocki

  • Status changed from needs_review to positive_review

comment:7 Changed 8 years ago by zabrocki

  • Reviewers set to Mike Zabrocki

comment:8 Changed 8 years ago by tscrim

  • Dependencies set to #14808
  • Status changed from positive_review to needs_work

Hey Christian,

Could you rebase this over #14808?

Thanks,
Travis

comment:9 Changed 8 years ago by stumpc5

Hi Travis, it looks like this bug was already fixed in #14808, am I right? Then please set this ticket to duplicate.

comment:10 Changed 8 years ago by tscrim

  • Authors Christian Stump deleted
  • Milestone changed from sage-5.12 to sage-duplicate/invalid/wontfix
  • Reviewers changed from Mike Zabrocki to Christian Stump
  • Status changed from needs_work to positive_review

Ah, yes it has. :P

comment:11 Changed 8 years ago by jdemeyer

  • Resolution set to duplicate
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.