Opened 8 years ago

Closed 7 years ago

#14855 closed enhancement (fixed)

Weierstrass form for complete intersection of two quadratic equations

Reported by: vbraun Owned by: mhampton
Priority: major Milestone: sage-6.1
Component: geometry Keywords: sd53
Cc: Merged in:
Authors: Volker Braun Reviewers: Jan Keitel
Report Upstream: N/A Work issues:
Branch: u/vbraun/weierstrass_p3 (Commits) Commit:
Dependencies: Stopgaps:

Description (last modified by vbraun)

Extends the current functionaly for hypersurfaces to the complete intersection of two quadratics in P^3 

    sage: R.<w,x,y,z> = QQ[]
    sage: quadratic1 = w^2+x^2+y^2
    sage: quadratic2 = z^2 + w*x
    sage: WeierstrassForm([quadratic1, quadratic2])
    (-1/4, 0)

Attachments (1)

trac_14855_weierstrass_complete_intersection.patch​ (80.6 KB) - added by vbraun 8 years ago.
Initial patch

Download all attachments as: .zip

Change History (8)

Changed 8 years ago by vbraun

Initial patch

comment:1 Changed 8 years ago by vbraun

  • Description modified (diff)

comment:2 Changed 7 years ago by jkeitel

  • Branch set to u/jkeitel/weierstrass_p3
  • Status changed from new to needs_review

comment:3 Changed 7 years ago by git

  • Commit set to 65199d1eaca6ee56aef574a7d9fab6e2eddf9a3d

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

[changeset:65199d1]Finished doctests.
[changeset:348061c]Added exception for what appears to be a doctest but is not.
[changeset:28ecde4]More docstrings and typos.
[changeset:68b3da6]Mostly minor changes to Volkers patch.
[changeset:80fe51d]# Fri Jul 05 01:45:09 2013 -0400
[changeset:3b15578]Merging Sage-5.12.beta5, newest dev scripts, and the doctest fixes.
[changeset:1456c52]Merge branch 'ticket/14482' into public/sage-git/master
[changeset:b890215]Merge branch 'ticket/14482' into public/sage-git/master
[changeset:d8713eb]Merge remote-tracking branch 'origin/build_system' into public/sage-git/master
[changeset:970090d]Merge branch 'u/ohanar/build_system'

comment:4 Changed 7 years ago by jkeitel

  • Commit 65199d1eaca6ee56aef574a7d9fab6e2eddf9a3d deleted
  • Keywords sd53 added
  • Milestone changed from sage-5.12 to sage-6.0
  • Reviewers set to Jan Keitel
  • Status changed from needs_review to positive_review

I changed a couple of minor things and tweaked the docstrings and doctests in a few cases. Volker sat down with me and is fine with the changes, so I'm putting this to positive review.

comment:5 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.0 to sage-6.1

comment:6 Changed 7 years ago by vbraun

  • Branch changed from u/jkeitel/weierstrass_p3 to u/vbraun/weierstrass_p3

comment:7 Changed 7 years ago by vbraun

  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.