Opened 12 years ago

Closed 12 years ago

#1485 closed enhancement (fixed)

[with bundle, with posititve review] wrapper for invariant_ring and invariant_algebra_reynolds in Singular

Reported by: wdj Owned by: wdj
Priority: major Milestone: sage-2.10.1
Component: commutative algebra Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by malb)

Wraps Singular's invariant_algebra_reynolds and invariant_ring in finvar.lib, with help from Simon King and Martin Albrecht. Computes generators for the polynomial ring F[x1,...,xn]G, where G in GL(n,F) is a finite matrix group.

In the "good characteristic" case the polynomials returned form a minimal generating set for the algebra of G-invariant polynomials. In the "bad" case, the polynomials returned are primary and secondary invariants, forming a not necessarily minimal generating set for the algebra of G-invariant polynomials.

Patch is at http://sage.math.washington.edu/home/wdj/patches/matrix_group20071213.hg and file is at http://sage.math.washington.edu/home/wdj/patches/matrix_group.py

Attachments (1)

matrix_group20071213.hg (2.0 KB) - added by malb 12 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 12 years ago by wdj

This is indirectly related to trac ticket http://sagetrac.org/sage_trac/ticket/1274 but does not resolve that issue.

comment:2 Changed 12 years ago by mabshoff

  • Summary changed from wrapper for invariant_ring and invariant_algebra_reynolds in Singular to [with bundle] wrapper for invariant_ring and invariant_algebra_reynolds in Singular

comment:3 Changed 12 years ago by rlm

  • Summary changed from [with bundle] wrapper for invariant_ring and invariant_algebra_reynolds in Singular to [with bundle, needs review] wrapper for invariant_ring and invariant_algebra_reynolds in Singular

comment:4 Changed 12 years ago by malb

  • Description modified (diff)

Changed 12 years ago by malb

comment:5 Changed 12 years ago by malb

  • Summary changed from [with bundle, needs review] wrapper for invariant_ring and invariant_algebra_reynolds in Singular to [with bundle, with positive review] wrapper for invariant_ring and invariant_algebra_reynolds in Singular

The patch applies cleanly and the doctests pass. I cannot check the results due to lack of knowledge, though. Good to go in, if you ask me.

comment:6 Changed 12 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged in Sage 2.10.alpha4

comment:7 Changed 12 years ago by mabshoff

  • Resolution fixed deleted
  • Status changed from closed to reopened

The patch causes hangs when doctesting plot/plot3d/transform.pyx. The really odd thing is that everything is fine when running that doctest with the -verbose flag.

Cheers,

Michael

comment:8 Changed 12 years ago by mabshoff

  • Summary changed from [with bundle, with positive review] wrapper for invariant_ring and invariant_algebra_reynolds in Singular to [with bundle, with negative review] wrapper for invariant_ring and invariant_algebra_reynolds in Singular

While somebody is at it: please attach single commit change sets as patch in the future.

Cheers,

Michael

comment:9 Changed 12 years ago by malb

  • Owner changed from malb to wdj
  • Status changed from reopened to new

comment:10 Changed 12 years ago by mabshoff

Mercurial is stupid: I applied this patch in alpha4, but reverted it by applying the inverse with patch and committed. But unbundling the bundle again doesn't commit *anything*.

Cheers,

Michael

comment:11 Changed 12 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed
  • Summary changed from [with bundle, with negative review] wrapper for invariant_ring and invariant_algebra_reynolds in Singular to [with bundle, with posititve review] wrapper for invariant_ring and invariant_algebra_reynolds in Singular
Note: See TracTickets for help on using tickets.