Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#14814 closed enhancement (fixed)

Multivariate power series are missing integral and division method

Reported by: hivert Owned by: AlexGhitza
Priority: major Milestone: sage-6.1
Component: algebra Keywords: integral multivariate power series
Cc: Merged in:
Authors: Florent Hivert, Nicolas M. Thiéry Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: u/vbraun/series_integral_div (Commits) Commit: 02333e33b825d09116f0ad8786638e764fcacfee
Dependencies: Stopgaps:

Description (last modified by darij)

sage: R.<x>=PowerSeriesRing(QQ, 'x')
sage: (x+x^2).integral()
1/2*x^2 + 1/3*x^3
sage: R.<x,y>=PowerSeriesRing(QQ, 'x y')
sage: (x+x^2).integral(x)
...
AttributeError: 'MPowerSeries' object has no attribute 'integral'

I also implement division by a non unit series (thanks Nicolas for preliminary code) and fixes the latex method which was buggy

Apply:

Attachments (3)

trac_14814-power_series_inverse_latex-fix-fh.patch (12.2 KB) - added by hivert 6 years ago.
trac_14814_review.patch (9.8 KB) - added by chapoton 6 years ago.
trac_14814-review-2-dg.patch (19.7 KB) - added by darij 6 years ago.
another review patch, atop of the previous one

Download all attachments as: .zip

Change History (17)

comment:1 Changed 6 years ago by hivert

  • Description modified (diff)

comment:2 Changed 6 years ago by hivert

  • Authors set to Florent Hivert, Nicolas Thiéry
  • Description modified (diff)
  • Status changed from new to needs_review
  • Summary changed from Mulitvariate power series are missing an integral method to Mulitvariate power series are missing integral and division method

comment:3 Changed 6 years ago by chapoton

this may interfere with #14334

comment:4 Changed 6 years ago by chapoton

  • Summary changed from Mulitvariate power series are missing integral and division method to Multivariate power series are missing integral and division method

comment:5 Changed 6 years ago by chapoton

It seems that there is no conflict with #14334

2 remarks:

  • there is a typo in quo_rem: increassing

comment:6 Changed 6 years ago by chapoton

I have made a review patch. If you are happy with the few small changes I have made, you can set a positive review.

Changed 6 years ago by chapoton

comment:7 Changed 6 years ago by chapoton

  • Reviewers set to Frédéric Chapoton

Ping ! Florent ? anybody else ?

comment:8 Changed 6 years ago by chapoton

Ping again ! Nobody available to have a look at this ticket ?

Changed 6 years ago by darij

another review patch, atop of the previous one

comment:9 Changed 6 years ago by darij

  • Description modified (diff)

New review patch allows the denominator to lie in a different parent (as long as it coerces into that of the numerator), deals with an endless-loop bug, and adds doc and comments. If you are fine with it, Frederic and Florent, this is positive_review!

for the patchbot

apply trac_14814-power_series_inverse_latex-fix-fh.patch​ trac_14814_review.patch​ trac_14814-review-2-dg.patch

comment:10 Changed 6 years ago by vbraun

  • Branch set to u/vbraun/series_integral_div

comment:11 Changed 6 years ago by vbraun

  • Commit set to 02333e33b825d09116f0ad8786638e764fcacfee
  • Status changed from needs_review to positive_review

New commits:

02333e3trac #14814: review patch
09c2670trac #14814 review patch (minor details)
aeea9a1Implement integration and division or power series.

comment:12 Changed 6 years ago by darij

Thanks for the final review, Volker!

comment:13 Changed 6 years ago by vbraun

  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:14 Changed 6 years ago by jdemeyer

  • Authors changed from Florent Hivert, Nicolas Thiéry to Florent Hivert, Nicolas M. Thiéry
Note: See TracTickets for help on using tickets.