#14814 closed enhancement (fixed)
Multivariate power series are missing integral and division method
Reported by: | hivert | Owned by: | AlexGhitza |
---|---|---|---|
Priority: | major | Milestone: | sage-6.1 |
Component: | algebra | Keywords: | integral multivariate power series |
Cc: | Merged in: | ||
Authors: | Florent Hivert, Nicolas M. Thiéry | Reviewers: | Frédéric Chapoton |
Report Upstream: | N/A | Work issues: | |
Branch: | u/vbraun/series_integral_div (Commits) | Commit: | 02333e33b825d09116f0ad8786638e764fcacfee |
Dependencies: | Stopgaps: |
Description (last modified by )
sage: R.<x>=PowerSeriesRing(QQ, 'x') sage: (x+x^2).integral() 1/2*x^2 + 1/3*x^3 sage: R.<x,y>=PowerSeriesRing(QQ, 'x y') sage: (x+x^2).integral(x) ... AttributeError: 'MPowerSeries' object has no attribute 'integral'
I also implement division by a non unit series (thanks Nicolas for preliminary code) and fixes the latex method which was buggy
Apply:
Attachments (3)
Change History (17)
comment:1 Changed 7 years ago by
- Description modified (diff)
comment:2 Changed 7 years ago by
- Description modified (diff)
- Status changed from new to needs_review
- Summary changed from Mulitvariate power series are missing an integral method to Mulitvariate power series are missing integral and division method
Changed 7 years ago by
comment:3 Changed 7 years ago by
comment:4 Changed 7 years ago by
- Summary changed from Mulitvariate power series are missing integral and division method to Multivariate power series are missing integral and division method
comment:5 Changed 7 years ago by
It seems that there is no conflict with #14334
2 remarks:
- there is a typo in quo_rem: increassing
- please use the new syntax ValueError?('please')
comment:6 Changed 7 years ago by
I have made a review patch. If you are happy with the few small changes I have made, you can set a positive review.
Changed 7 years ago by
comment:8 Changed 7 years ago by
Ping again ! Nobody available to have a look at this ticket ?
comment:9 Changed 7 years ago by
- Description modified (diff)
New review patch allows the denominator to lie in a different parent (as long as it coerces into that of the numerator), deals with an endless-loop bug, and adds doc and comments. If you are fine with it, Frederic and Florent, this is positive_review!
for the patchbot
apply trac_14814-power_series_inverse_latex-fix-fh.patch trac_14814_review.patch trac_14814-review-2-dg.patch
comment:10 Changed 7 years ago by
- Branch set to u/vbraun/series_integral_div
comment:11 Changed 7 years ago by
- Commit set to 02333e33b825d09116f0ad8786638e764fcacfee
- Status changed from needs_review to positive_review
comment:12 Changed 7 years ago by
Thanks for the final review, Volker!
comment:13 Changed 7 years ago by
- Resolution set to fixed
- Status changed from positive_review to closed
this may interfere with #14334