Opened 8 years ago
Closed 8 years ago
#14813 closed enhancement (fixed)
Finitely generated abelian group presentations
Reported by: | dshurbert | Owned by: | tbd |
---|---|---|---|
Priority: | minor | Milestone: | sage-5.13 |
Component: | group theory | Keywords: | abelian group presentations |
Cc: | rbeezer, vbraun, mmarco | Merged in: | sage-5.13.beta1 |
Authors: | Davis Shurbert | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | #14790, #14791 | Stopgaps: |
Description (last modified by )
Method to construct finitely generated abelian groups as quotients of free groups. User inputs a list of integers to define an abelian group, then the invariants of the input list are used to build the group as a finite presentation.
sage:groups.presentation.FGAbelian([2,2]) Finitely presented group < a, b | a^2, b^2, a^-1*b^-1*a*b > sage: groups.presentation.FGAbelian([6,3,5,17]) Finitely presented group < a, b | a^3, b^510, a^-1*b^-1*a*b >
Depends on #14791, which creates the "named" finitely presented groups infrastructure, and #14790 which gives the python generator needed for variable names.
Apply
Attachments (1)
Change History (13)
comment:1 Changed 8 years ago by
- Description modified (diff)
comment:2 Changed 8 years ago by
- Description modified (diff)
comment:3 Changed 8 years ago by
- Description modified (diff)
- Status changed from new to needs_info
comment:4 Changed 8 years ago by
- Component changed from PLEASE CHANGE to group theory
comment:5 Changed 8 years ago by
- Status changed from needs_info to needs_review
comment:6 Changed 8 years ago by
- Status changed from needs_review to needs_work
comment:7 Changed 8 years ago by
- Status changed from needs_work to needs_review
Rebased the patch on this ticket to the review patch on #14791
comment:8 Changed 8 years ago by
- Reviewers set to Travis Scrimshaw
Hey,
One minor thing, instead of \mathbb{Z}
, could you use \ZZ
so Sage's documentation is consistent? Other than that, it looks good to me.
Best,
Travis
comment:9 Changed 8 years ago by
Fixed documentation inconsistencies, thanks for the tip.
Davis
comment:11 Changed 8 years ago by
- Milestone changed from sage-5.12 to sage-5.13
comment:12 Changed 8 years ago by
- Merged in set to sage-5.13.beta1
- Resolution set to fixed
- Status changed from positive_review to closed
Rebasing to review patch on #14791