Opened 7 years ago
Closed 6 years ago
#14810 closed enhancement (fixed)
Update to ipython-0.13.2
Reported by: | vbraun | Owned by: | jdemeyer |
---|---|---|---|
Priority: | major | Milestone: | sage-5.12 |
Component: | packages: standard | Keywords: | |
Cc: | jason | Merged in: | sage-5.12.beta4 |
Authors: | Volker Braun | Reviewers: | John Palmieri |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
http://boxen.math.washington.edu/home/vbraun/spkg/ipython-0.13.2.spkg
Apply trac_14810_ipython_0.13.2.patch to the Sage library
Attachments (1)
Change History (16)
comment:1 Changed 7 years ago by
comment:2 Changed 7 years ago by
- Cc jason added
- Description modified (diff)
- Status changed from new to needs_review
comment:3 Changed 7 years ago by
All doctests pass!
comment:4 Changed 7 years ago by
In SPKG.txt
:
=== ipython-0.13.1 (Volker Braun, June 24, 2013) === * Upgrade to 0.13.2
On the first line, it should say 0.13.2. I also prefer listing the trac ticket also, as in
* Upgrade to 0.13.2 (trac #14810)
(Or list it in the mercurial commit message.)
Otherwise, it looks good.
comment:5 Changed 7 years ago by
- Reviewers set to John Palmieri
- Status changed from needs_review to positive_review
Thanks!
Manually bookkeeping of revisions / trac tickets is of course precisely the mindless busywork that the source control system should do for you. Can't wait to switch to a unified git repo..
In any case I made the manual change and updated the spkg.
comment:6 Changed 7 years ago by
Just FYI, I'm keeping track of patches needed to move to 1.0 (due out soon): #14713
comment:7 Changed 7 years ago by
- Status changed from positive_review to needs_work
Typo in version number in SPKG.txt
:
=== ipython-0.13.1 (Volker Braun, June 24, 2013) === * Upgrade to 0.13.2 (trac #14810)
comment:8 Changed 7 years ago by
- Status changed from needs_work to positive_review
fixed in the updated spkg.
comment:9 Changed 7 years ago by
- Status changed from positive_review to needs_work
The exit status of false
is 255 on Solaris:
sage -t --long devel/sage/sage/misc/interpreter.py ********************************************************************** File "devel/sage/sage/misc/interpreter.py", line 175, in sage.misc.interpreter.SageInteractiveShell.system_raw Failed example: shell.user_ns['_exit_code'] Expected: 1 Got: 255 **********************************************************************
comment:10 Changed 7 years ago by
- Status changed from needs_work to needs_review
0=True and 255=False? Oooo... I changed the test to
sage: shell.system_raw('false') sage: shell.user_ns['_exit_code'] > 0 True
comment:11 Changed 7 years ago by
Apparently POSIX says false
exits with code not zero: http://www.unix.com/man-page/POSIX/1posix/false/
comment:12 Changed 7 years ago by
I agree that its legal, just an odd choice ;-)
comment:13 Changed 7 years ago by
Yeah. Maybe they just wanted to return 1 in every bit, not just in the smallest bit.
comment:14 Changed 7 years ago by
- Status changed from needs_review to positive_review
comment:15 Changed 6 years ago by
- Merged in set to sage-5.12.beta4
- Resolution set to fixed
- Status changed from positive_review to closed
Patch necessary because meaning of
user_ns['_exit_code']
changed, see https://github.com/ipython/ipython/pull/2799