Opened 7 years ago
Closed 7 years ago
#14805 closed enhancement (fixed)
Adds sage.graphs.base.graph_backend to the documentation
Reported by: | ncohen | Owned by: | jason, ncohen, rlm |
---|---|---|---|
Priority: | trivial | Milestone: | sage-5.12 |
Component: | graph theory | Keywords: | |
Cc: | Merged in: | sage-5.12.beta0 | |
Authors: | Nathann Cohen | Reviewers: | Punarbasu Purkayastha |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
Attachments (1)
Change History (20)
comment:1 Changed 7 years ago by
- Status changed from new to needs_review
comment:2 Changed 7 years ago by
- Priority changed from major to trivial
comment:3 Changed 7 years ago by
comment:4 Changed 7 years ago by
Sorrysorry I just did ! ;-)
Nathann
comment:5 Changed 7 years ago by
Can you add the following:
- After every description
iterator
, add what it is an iterator of. In some cases it is clearly mentioned, whereas in other cases it is simply left asiterator
. - There are some
INPUT
descriptions like this:- ``new`` -- boolean or None
or- ``new`` -- string or None
. I think it should be explicitly mentioned thatNone
corresponds to retrieving the current value. In fact, I am very surprised how it works. The function definition should be like the definition below so thatG.loops()
gives the value straightaway, without having to enterNone
as a function argument:def loops(self, new=None):
It is a painful and extensive cleanup of that file. Thanks for the effort. :)
comment:6 Changed 7 years ago by
- There is this sentence which needs spaces around the
=
, otherwise the rendered output is weird.81 If ``name``=``None``, the new vertex name is returned, ``None`` otherwise. 784 If ``name``=``None``, the new vertex name is returned. ``None`` otherwise.
- This needs a double backticks; currently it is rendered in latex
201 label of `(u,v)`
- It applied with one hunk at fuzz 2 against 5.11.beta3.
comment:7 Changed 7 years ago by
Hellooooooo !
I just updated the patch (sorry for the delay, I had some problems with Sage because of #14737), and fixed all your points.
Except point 4, where I removed the backticks instead of adding them : the whole file is full of (u,v) without backticks, and to me marking them with double backticks makes less sense than writing them as LaTeX characters. To me an edge is a math thing.
Well, what do you think ? We can make it Python, Maths, or let it stay like that too :-)
Nathann
comment:8 Changed 7 years ago by
Only one correction to suggest. In the correction to point 2, the `None`
should not be under single backticks. I am ok with removing the backticks from (u,v)
.
comment:9 Changed 7 years ago by
Oh sorry. there is another one of the point 2 type.
1362 - ``new`` -- string or None
comment:10 Changed 7 years ago by
Gloops. Right. Patch updated !
Nathann
Changed 7 years ago by
comment:11 Changed 7 years ago by
- Description modified (diff)
- Reviewers set to Punarbasu Purkayastha
- Status changed from needs_review to positive_review
Thanks. Looks good to me. :)
comment:12 Changed 7 years ago by
Thanks for the review :-)
Nathann
comment:13 Changed 7 years ago by
Why is the patchbot unable to apply to 5.11b3? I applied to 5.11b3 and it worked except for the fuzz.
comment:14 Changed 7 years ago by
It is probably an old version. The one I uploaded when you quoted the patchbot, yesterday.
Nathann
comment:15 Changed 7 years ago by
Let's kick the patchbot.
Apply trac_14805.patch
comment:16 follow-up: ↓ 17 Changed 7 years ago by
Underfed, then kicked.
We really should treat it better.
Nathann
comment:17 in reply to: ↑ 16 ; follow-up: ↓ 18 Changed 7 years ago by
Replying to ncohen:
Underfed, then kicked.
We really should treat it better.
Nathann
"C'est la vie" :-P
comment:18 in reply to: ↑ 17 Changed 7 years ago by
"C'est la vie"
:-P
In life you have to kick back if people treat you like that :-P
Nathann
comment:19 Changed 7 years ago by
- Merged in set to sage-5.12.beta0
- Resolution set to fixed
- Status changed from positive_review to closed
Patchbot says "mmmm... tasty but can't digest; need rebase."
Edit: That's evil. You upload a new patch in the few seconds while I write.
X-(