Opened 6 years ago

Closed 5 years ago

#14802 closed defect (fixed)

improve dynamic attributes of symbolic expressions

Reported by: burcin Owned by: burcin
Priority: major Milestone: sage-6.2
Component: symbolics Keywords: sd48
Cc: vbraun, eviatarbach Merged in:
Authors: Burcin Erocal Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: 5c579d8 (Commits) Commit: 5c579d8cbf34fe86d239b63c108f9c0980493a0a
Dependencies: #14780 Stopgaps:

Description (last modified by burcin)

Symbolic functions can define dynamic attributes that will be added to symbolic expressions representing evaluated forms of these functions (#9556).

This patch extends the existing functionality to allow these attributes to take arbitrary arguments. It also passes the function class and the symbolic expression as arguments.

Apply: trac_14802-dynamic_attribute_args.patch

Attachments (1)

trac_14802-dynamic_attribute_args.patch (5.8 KB) - added by burcin 6 years ago.

Download all attachments as: .zip

Change History (18)

comment:1 Changed 6 years ago by burcin

  • Dependencies set to #14780
  • Description modified (diff)
  • Status changed from new to needs_review

comment:2 Changed 6 years ago by vbraun

  • Cc vbraun added

comment:3 Changed 6 years ago by eviatarbach

  • Cc eviatarbach added

comment:4 follow-up: Changed 6 years ago by vbraun

I'm getting doctest failures:

sage -t sage/symbolic/function_factory.py  # 1 doctest failed
sage -t sage/symbolic/expression.pyx  # 3 doctests failed

Missing dependency?

Changed 6 years ago by burcin

comment:5 in reply to: ↑ 4 Changed 6 years ago by burcin

Replying to vbraun:

I'm getting doctest failures:

sage -t sage/symbolic/function_factory.py  # 1 doctest failed
sage -t sage/symbolic/expression.pyx  # 3 doctests failed

Missing dependency?

I forgot to update the documentation after adding the new function class argument. Updated patch attached.

comment:6 Changed 6 years ago by vbraun

  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

looks good to me

comment:7 Changed 6 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:8 Changed 6 years ago by jdemeyer

  • Milestone changed from sage-5.12 to sage-pending

comment:9 Changed 5 years ago by vbraun

  • Branch set to u/vbraun/improve_dynamic_attributes_of_symbolic_expressions

comment:10 Changed 5 years ago by vbraun

  • Commit set to a6bea6448c6848ce1aca4dc5efc2f5108c308fee

Merge conflict with sage-6.2.beta6 will have to be resolved


New commits:

a6bea64Import of trac_14802-dynamic_attribute_args.patch from

comment:11 Changed 5 years ago by rws

  • Branch changed from u/vbraun/improve_dynamic_attributes_of_symbolic_expressions to public/14802
  • Created changed from 06/21/13 22:20:25 to 06/21/13 22:20:25
  • Modified changed from 03/31/14 15:15:41 to 03/31/14 15:15:41

comment:12 Changed 5 years ago by rws

  • Commit changed from a6bea6448c6848ce1aca4dc5efc2f5108c308fee to 80851f66351869a47e2982b378be01d96fb8f3d9

rebased on 6.2.beta6


New commits:

80851f6Merge branch 'u/vbraun/improve_dynamic_attributes_of_symbolic_expressions' of ssh://trac.sagemath.org/sage into ticket/14802

comment:13 Changed 5 years ago by rws

  • Branch changed from public/14802 to public/14802-1
  • Commit changed from 80851f66351869a47e2982b378be01d96fb8f3d9 to 32e801a7674f97d4ea6e0441dcd13577914b2bd4
  • Type changed from enhancement to defect

rebased on 6.2.beta7


New commits:

32e801aImport of trac_14802-dynamic_attribute_args.patch from

comment:14 Changed 5 years ago by rws

  • Milestone changed from sage-pending to sage-6.2

comment:15 Changed 5 years ago by vbraun

Tabs are not allowed, can you convert it to spaces?

sage -t --long src/sage/symbolic/pynac.pyx  # Tab character found

comment:16 Changed 5 years ago by git

  • Commit changed from 32e801a7674f97d4ea6e0441dcd13577914b2bd4 to 5c579d8cbf34fe86d239b63c108f9c0980493a0a
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

5c579d814802: remove tabs

comment:17 Changed 5 years ago by vbraun

  • Branch changed from public/14802-1 to 5c579d8cbf34fe86d239b63c108f9c0980493a0a
  • Resolution set to fixed
  • Status changed from needs_review to closed
Note: See TracTickets for help on using tickets.