Opened 7 years ago
Closed 7 years ago
#14787 closed enhancement (fixed)
Statistics on generalized Young walls
Reported by: | bsalisbury1 | Owned by: | sage-combinat |
---|---|---|---|
Priority: | major | Milestone: | sage-5.12 |
Component: | combinatorics | Keywords: | generalized Young wall, days49 |
Cc: | tscrim | Merged in: | sage-5.12.beta4 |
Authors: | Ben Salisbury | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | #14769, #14382 | Stopgaps: |
Description
Implement two statistics on generalized Young walls.
Attachments (2)
Change History (17)
comment:1 Changed 7 years ago by
- Status changed from new to needs_review
comment:2 Changed 7 years ago by
comment:3 Changed 7 years ago by
Changed .N() to .number_of_parts() and .M() to .sum_of_weighted_row_lengths().
comment:4 Changed 7 years ago by
Eliminated recursion from number_of_parts method.
comment:5 Changed 7 years ago by
- Reviewers set to Travis Scrimshaw
- Status changed from needs_review to positive_review
Looks good to me.
comment:6 Changed 7 years ago by
- Dependencies changed from 14769 to #14769
- Milestone changed from sage-5.11 to sage-5.12
comment:7 Changed 7 years ago by
- Status changed from positive_review to needs_work
The PDF documentation doesn't build:
! Undefined control sequence. <recently read> \mathscr l.128428 Return the value of $\mathscr {N}$ on \code{self}. ? Chapter 7. [17 [1] [48]] ! Emergency stop. <recently read> \mathscr l.128428 Return the value of $\mathscr {N}$ on \code{self}. ! ==> Fatal error occurred, no output PDF file produced! Transcript written on combinat.log. [147] (/usr/share/texmf-texlive/tex/latex/psnfss/ts1ptm.fd)make[1]: *** [combinat.pdf] Error 1
comment:8 follow-up: ↓ 9 Changed 7 years ago by
Hey Jeroen and Ben,
It seems like the pdf builder doesn't include the package(s) to support \mathscr
, even though the html/mathjax does. Jeroen, could we include mathrsfs
as part of the pdf build (possibly [also] amsfonts
), or should we just change this to use \mathcal
instead?
Thanks,
Travis
comment:9 in reply to: ↑ 8 Changed 7 years ago by
Replying to tscrim:
could we include
mathrsfs
as part of the pdf build (possibly [also]amsfonts
)
If those packages are reasonably standard packages and included with most LaTeX distributions, then yes.
comment:10 Changed 7 years ago by
The mathrsfs package was added misc/latex.py.
Changed 7 years ago by
comment:11 Changed 7 years ago by
- Status changed from needs_work to positive_review
I also had to add it to doc/common/conf.py
.
comment:12 Changed 7 years ago by
- Dependencies changed from #14769 to #14769, #14382
- Status changed from positive_review to needs_work
This needs to be rebased to #14382.
Changed 7 years ago by
comment:13 Changed 7 years ago by
- Status changed from needs_work to needs_review
comment:15 Changed 7 years ago by
- Merged in set to sage-5.12.beta4
- Resolution set to fixed
- Status changed from positive_review to closed
Hey Ben,
Could you put some line breaks in the bullet point on lines 265, 267? Also could you (and/or coauthors) create more descriptive names for these statistics?
Thanks,
Travis