Opened 6 years ago

Closed 6 years ago

#14783 closed enhancement (fixed)

Implement toggle group actions on posets

Reported by: jessicapalencia Owned by: sage-combinat
Priority: major Milestone: sage-5.12
Component: combinatorics Keywords: poset, combinat, days49
Cc: yanzhang, rowland, darij Merged in: sage-5.12.beta3
Authors: Jessica Striker, Darij Grinberg Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #12848, #14267 Stopgaps:

Description (last modified by darij)

  1. Implement toggling a single elements in an order ideal
  2. Toggle a list of elements
  3. Implement row and column toggles
  4. Implement promotion and rowmotion
  5. Implement orbit structure calculator

Attachments (4)

order-ideals.patch (8.4 KB) - added by darij 6 years ago.
today's work
trac_14783-toggles_on_order_ideals-jsdg.patch (17.9 KB) - added by darij 6 years ago.
now with commit msg
trac_14783-toggles_on_order_ideals-jsdg.2.patch (17.4 KB) - added by darij 6 years ago.
now with useless whitespace edit removed
trac_14783-toggles_on_order_ideals-jsdg-2.patch (17.4 KB) - added by darij 6 years ago.

Download all attachments as: .zip

Change History (22)

Changed 6 years ago by darij

today's work

comment:1 Changed 6 years ago by darij

  • Status changed from new to needs_review

comment:2 Changed 6 years ago by chapoton

please add a commit message

comment:3 Changed 6 years ago by darij

  • Description modified (diff)

comment:4 Changed 6 years ago by darij

Right, done.

comment:5 Changed 6 years ago by chapoton

for the bot:

apply trac_14783-toggles_on_order_ideals-jsdg.patch

comment:6 Changed 6 years ago by tscrim

Hey Darij,

A few more things:

  • There's a "TODO" on line 371 of finite_posets.py, I believe that should be removed,
  • element_constructor of rowmotion_orbits is not documented,
  • "Returns" -> "Return",
  • In categories/posets.py, could you make the `I`'s into ``I`` and similar for `v` and `vs` (i.e. code formatting),
  • Could the is_order_* methods be moved into the category Posets?

Thanks,
Travis

Changed 6 years ago by darij

now with commit msg

comment:7 Changed 6 years ago by darij

Good points, done! The diff for finite_posets.py is a bit weird, but it should work. I've also caught and fixed two wrong docstrings in sage/categories/posets.py.

The discrepancy between the lines 376 and 381 in finite_posets.py might itself be worth a ticket...

Last edited 6 years ago by darij (previous) (diff)

Changed 6 years ago by darij

now with useless whitespace edit removed

comment:8 Changed 6 years ago by darij

  • Description modified (diff)

comment:9 Changed 6 years ago by chapoton

once again, your new patch needs a commit message, see the patchbot report

imho, having the patchbot green is a reasonable first step before starting the review process

comment:10 Changed 6 years ago by darij

Huh? Doesn't it say "trac #14783: implement toggle operations on order ideals of a poset"?

For patchbot:

apply trac_14783-toggles_on_order_ideals-jsdg.2.patch

Last edited 6 years ago by darij (previous) (diff)

comment:11 Changed 6 years ago by chapoton

yes indeed, but for the some reasons the bot managed to stack two patches that were not supposed to be stacked. And order-ideals.patch has no commit message..

comment:12 Changed 6 years ago by tscrim

  • Authors changed from Jessica Striker to Jessica Striker, Darij Grinberg
  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

Looks good to me.

It's strange (and somewhat scary to me) the patchbot was able to apply both patches...

comment:13 Changed 6 years ago by darij

Thank you!

(I also don't see why the patchbot has been trying to do so in the first place...)

comment:14 Changed 6 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:15 Changed 6 years ago by jdemeyer

  • Dependencies changed from #12848 to #12848, #14267
  • Status changed from positive_review to needs_work

This needs to be rebased to #14267.

comment:16 Changed 6 years ago by darij

  • Status changed from needs_work to positive_review

Here trac_14783-toggles_on_order_ideals-jsdg-2.patch is the rebase. Sorry for the confusing filename; ignore all the other attachments.

patchbot:

apply trac_14783-toggles_on_order_ideals-jsdg-2.patch

comment:17 Changed 6 years ago by darij

  • Description modified (diff)

comment:18 Changed 6 years ago by jdemeyer

  • Merged in set to sage-5.12.beta3
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.