Opened 8 years ago

Closed 8 years ago

#14776 closed enhancement (fixed)

enhancement: Implementation of strong k-tableaux

Reported by: zabrocki Owned by: zabrocki
Priority: major Milestone: sage-5.12
Component: combinatorics Keywords: tableaux, days49
Cc: aschiling, npgallup Merged in: sage-5.12.rc0
Authors: Mike Zabrocki Reviewers: Anne Schilling
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #12250 Stopgaps:

Status badges

Description (last modified by zabrocki)

The dual k-schur functions in the Symmetric Function package have a combinatorial expansion in terms of strong k-tableaux. This ticket implements the classes of StrongTableau and StrongTableaux as well as methods for manipulating these objects

Attachments (1)

trac_14776-strong-ktableaux-mz.patch (98.7 KB) - added by zabrocki 8 years ago.

Download all attachments as: .zip

Change History (17)

comment:1 Changed 8 years ago by zabrocki

  • Cc npgallup added

comment:2 Changed 8 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:3 Changed 8 years ago by zabrocki

  • Authors changed from zabrocki, aschilling to Mike Zabrocki
  • Description modified (diff)
  • Reviewers set to Anne Schilling

comment:4 Changed 8 years ago by zabrocki

  • Status changed from new to needs_review

comment:5 Changed 8 years ago by zabrocki

  • Description modified (diff)

comment:6 Changed 8 years ago by aschilling

Mike and I just met and reviewed and discussed the code together. All changes that I requested were incorporated, so I am happy with the code.

Positive review!

Anne

comment:7 Changed 8 years ago by aschilling

  • Status changed from needs_review to positive_review

comment:8 Changed 8 years ago by zabrocki

I realized that there was an inconsistency with the name of one of the methods and changed content_of_marked_ribbon to content_of_marked_head

comment:9 Changed 8 years ago by zabrocki

Thanks for the positive review and for the visit in Montreal.

comment:10 Changed 8 years ago by jdemeyer

  • Status changed from positive_review to needs_work
sage -t --long devel/sage/sage/combinat/core.py
**********************************************************************
File "devel/sage/sage/combinat/core.py", line 379, in sage.combinat.core.Core.weak_le
Failed example:
    c.weak_le(x)
Expected:
    Traceback (most recent call last):
    ...
    AssertionError: The two cores do not have the same k
Got:
    <BLANKLINE>
    Traceback (most recent call last):
      File "/scratch/release/merger/sage-5.12.rc0/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 479, in _run
        self.execute(example, compiled, test.globs)
      File "/scratch/release/merger/sage-5.12.rc0/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 838, in execute
        exec compiled in globs
      File "<doctest sage.combinat.core.Core.weak_le[7]>", line 1, in <module>
        c.weak_le(x)
      File "/scratch/release/merger/sage-5.12.rc0/local/lib/python2.7/site-packages/sage/combinat/core.py", line 386, in weak_le
        raise ValueError("The two cores do not have the same k")
    ValueError: The two cores do not have the same k
**********************************************************************

comment:11 follow-up: Changed 8 years ago by zabrocki

  • Status changed from needs_work to needs_review

That was unexpected, but easily changed.

comment:12 in reply to: ↑ 11 Changed 8 years ago by aschilling

Hi Mike,

That was unexpected, but easily changed.

Did you fix the error? I still get the same error that Jeroen reported

combinat anne$ sage -t --long core.py 
Running doctests with ID 2013-09-27-11-38-00-bec5fc69.
Doctesting 1 file.
sage -t --long core.py
**********************************************************************
File "core.py", line 379, in sage.combinat.core.Core.weak_le
Failed example:
    c.weak_le(x)
Expected:
    Traceback (most recent call last):
    ...
    AssertionError: The two cores do not have the same k
Got:
    <BLANKLINE>
    Traceback (most recent call last):
      File "/Applications/sage-5.12.beta5/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 479, in _run
        self.execute(example, compiled, test.globs)
      File "/Applications/sage-5.12.beta5/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 838, in execute
        exec compiled in globs
      File "<doctest sage.combinat.core.Core.weak_le[7]>", line 1, in <module>
        c.weak_le(x)
      File "/Applications/sage-5.12.beta5/local/lib/python2.7/site-packages/sage/combinat/core.py", line 386, in weak_le
        raise ValueError("The two cores do not have the same k")
    ValueError: The two cores do not have the same k
**********************************************************************
1 item had failures:
   1 of   9 in sage.combinat.core.Core.weak_le
    [119 tests, 1 failure, 9.02 s]
----------------------------------------------------------------------
sage -t --long core.py  # 1 doctest failed
----------------------------------------------------------------------
Total time for all tests: 9.2 seconds
    cpu time: 4.9 seconds
    cumulative wall time: 9.0 seconds

Also, doing a diff, I cannot see that you changed any content

hg diff
diff --git a/trac_14776-strong-ktableaux-mz.patch b/trac_14776-strong-ktableaux-mz.patch
--- a/trac_14776-strong-ktableaux-mz.patch
+++ b/trac_14776-strong-ktableaux-mz.patch
@@ -1,5 +1,8 @@
 # HG changeset patch
-# Parent 58eed6940f88ab629a22eec9627878cdd23e6566
+# User Mike Zabrocki
+# Date 1376683423 14400
+# Node ID bb1ee08d656b6426a6fe76dd2aee284284343a2a
+# Parent  85cc8a56797b4f299b118bff6ba8cffcdb3e421f
 #14776 : implements StrongTableau and StrongTableaux classes
 
 diff --git a/sage/combinat/all.py b/sage/combinat/all.py

Best,

Anne

Changed 8 years ago by zabrocki

comment:13 follow-up: Changed 8 years ago by zabrocki

Sorry. I failed to qrefresh before exporting.

comment:14 in reply to: ↑ 13 Changed 8 years ago by aschilling

Replying to zabrocki:

Sorry. I failed to qrefresh before exporting.

Ok, looks good now.

Anne

comment:15 Changed 8 years ago by aschilling

  • Status changed from needs_review to positive_review

comment:16 Changed 8 years ago by jdemeyer

  • Merged in set to sage-5.12.rc0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.