Opened 8 years ago

Closed 8 years ago

#14765 closed defect (fixed)

ASM.to_monotone_triangle broken

Reported by: stumpc5 Owned by: sage-combinat
Priority: major Milestone: sage-5.11
Component: combinatorics Keywords: monotone triangle
Cc: chrisjamesberg, VivianePons, tscrim Merged in: sage-5.11.beta3
Authors: Travis Scrimshaw Reviewers: Christian Stump
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

sage: D = DyckWord([])
sage: ASM = D.to_alternating_sign_matrix()
sage: ASM.to_monotone_triangle()

BOOM!

Attachments (1)

trac_14765-fix_empty_GT_toprow-ts.patch (1.6 KB) - added by tscrim 8 years ago.

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by tscrim

comment:1 Changed 8 years ago by tscrim

  • Authors set to Travis Scrimshaw
  • Status changed from new to needs_review

It was because GT patterns did not take into account (the corner case) of an empty top row.

comment:2 Changed 8 years ago by stumpc5

  • Reviewers set to Christian Stump
  • Status changed from needs_review to positive_review

Looks good, thanks!

comment:3 Changed 8 years ago by jdemeyer

  • Merged in set to sage-5.11.beta3
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.