Opened 8 years ago

Closed 10 months ago

Last modified 10 months ago

#14764 closed defect (fixed)

Let Mathematica free integration work with definite integrals

Reported by: kcrisman Owned by: burcin
Priority: major Milestone: sage-9.2
Component: calculus Keywords:
Cc: Merged in:
Authors: Emmanuel Charpentier Reviewers: Travis Scrimshaw, Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 18385a7 (Commits, GitHub, GitLab) Commit:
Dependencies: Stopgaps:

Status badges

Description

See ​this ask.sagemath question. Apparently 

sage: integrate(x^2,x,algorithm='mathematica_free')
1/3*x^3
sage: integrate(x^2,x,0,1,algorithm='mathematica_free')
1/3*x^3

so that would be useful to fix. Since it currently returns an indefinite integral when we ask for a definite one, I'll classify this as a defect.

Change History (18)

comment:1 Changed 8 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:2 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:3 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:4 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:5 Changed 10 months ago by charpent

  • Milestone changed from sage-6.4 to sage-duplicate/invalid/wontfix
  • Status changed from new to needs_review

This seems fixed in recent Sage versions. IN 9.2.beta0: 

sage: integrate(x^2,x,0,1,algorithm='mathematica_free')
1/3
sage: integrate(sin(x),x,0,pi,algorithm='mathematica_free')
2
sage: integrate(sqrt(x),x,0,1,algorithm='mathematica_free')
2/3
sage: integrate(sqrt(x),x)
2/3*x^(3/2)

comment:6 follow-up: Changed 10 months ago by kcrisman

Needs doctest if these aren't already tested (which they may be).

comment:7 in reply to: ↑ 6 Changed 10 months ago by charpent

Replying to kcrisman:

Needs doctest if these aren't already tested (which they may be).

Right. Putting this to needs_work.

comment:8 Changed 10 months ago by charpent

  • Status changed from needs_review to needs_work

comment:9 Changed 10 months ago by charpent

  • Branch set to u/charpent/let_mathematica_free_integration_work_with_definite_integrals

comment:10 Changed 10 months ago by charpent

  • Authors set to Emmanuel Charpentier
  • Branch u/charpent/let_mathematica_free_integration_work_with_definite_integrals deleted
  • Milestone changed from sage-duplicate/invalid/wontfix to sage-9.2
  • Status changed from needs_work to needs_review

Added relevant doctests to src/sage/symbolics/integratin/external.py, which pass for me.

==>needs_review

comment:11 Changed 10 months ago by tscrim

  • Branch set to u/charpent/let_mathematica_free_integration_work_with_definite_integrals
  • Commit set to ced138e48c69e4d628774adf37830ff6c3ebd26d
  • Reviewers set to Travis Scrimshaw

New commits:

​ced138eDoctests for definite integral using mathematica_free.

comment:12 Changed 10 months ago by tscrim

Some fixes are needed: 

-    ::
 
-    Check that :trac:`14764` is resolved:
+    Check that :trac:`14764` is resolved::

comment:13 Changed 10 months ago by charpent

  • Status changed from needs_review to needs_work

Aaaarghhh!!! Sphinx is exceedingly prone to punctuation errors.

I'm on it.

comment:14 Changed 10 months ago by git

  • Commit changed from ced138e48c69e4d628774adf37830ff6c3ebd26d to 18385a7c38275f3e3841ab2230b1e1465213ea09

Branch pushed to git repo; I updated commit sha1. New commits:

​18385a7Punctiation fic for doctests for definite integral using mathematica_free.

comment:15 Changed 10 months ago by charpent

  • Status changed from needs_work to needs_review

Done. needs_review

comment:16 Changed 10 months ago by chapoton

  • Reviewers changed from Travis Scrimshaw to Travis Scrimshaw, Frédéric Chapoton
  • Status changed from needs_review to positive_review

allons-y !

comment:17 Changed 10 months ago by vbraun

  • Branch changed from u/charpent/let_mathematica_free_integration_work_with_definite_integrals to 18385a7c38275f3e3841ab2230b1e1465213ea09
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:18 Changed 10 months ago by slabbe

  • Commit 18385a7c38275f3e3841ab2230b1e1465213ea09 deleted

I think it was fixed in #25501

Note: See TracTickets for help on using tickets.