Opened 8 years ago

Closed 8 years ago

#14762 closed enhancement (fixed)

More combinatorial maps on alternating sign matrices

Reported by: jessicapalencia Owned by: sage-combinat
Priority: major Milestone: sage-5.11
Component: combinatorics Keywords: asm, days49
Cc: chrisjamesberg, tscrim Merged in: sage-5.11.rc0
Authors: Jessica Striker Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #14456 Stopgaps:

Status badges

Description (last modified by jessicapalencia)

Adds the combinatorial_map decorator to combinatorial maps on alternating sign matrices and fixes the bug that != does not compare correctly.

Attachments (2)

trac_14762-alt_sign_matrices-js.patch (1.2 KB) - added by jessicapalencia 8 years ago.
trac_14762-fix_ASM_ne-ts.patch (1.1 KB) - added by tscrim 8 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 8 years ago by jessicapalencia

  • Cc chrisjamesberg tscrim added
  • Description modified (diff)
  • Status changed from new to needs_review

comment:2 Changed 8 years ago by jessicapalencia

  • Keywords days49 added

I moved the other things from the original description to #14770.

comment:3 Changed 8 years ago by chrisjamesberg

  • Status changed from needs_review to needs_work

Needs to be rebased. Does not apply to 5.10.rc1.

Changed 8 years ago by jessicapalencia

comment:4 Changed 8 years ago by jessicapalencia

  • Status changed from needs_work to needs_review

fixed

comment:5 Changed 8 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

Looks good to me.

comment:6 Changed 8 years ago by tscrim

  • Status changed from needs_review to needs_work

ASM's do not compare not equal correctly, will fix shortly.

Changed 8 years ago by tscrim

comment:7 Changed 8 years ago by tscrim

  • Status changed from needs_work to needs_review

Review patch needing review.

comment:8 Changed 8 years ago by jessicapalencia

  • Description modified (diff)
  • Status changed from needs_review to positive_review

comment:9 Changed 8 years ago by jdemeyer

  • Merged in set to sage-5.11.rc0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.