Opened 8 years ago

Closed 8 years ago

#14761 closed defect (duplicate)

SkewTableau does follow global_options of Tableaux

Reported by: zabrocki Owned by: sage-combinat
Priority: minor Milestone: sage-duplicate/invalid/wontfix
Component: combinatorics Keywords: tableaux, days49
Cc: tscrim, chrisjamesberg Merged in:
Authors: Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #14101 Stopgaps:

Status badges

Description

SkewTableau should follow the same the conventions set in Tableaux.global_options for the method .pp(). In particular, it should follow convention="French" displayed in reverse order. This should be changed in the method _repr_diagram

Change History (10)

comment:1 Changed 8 years ago by tscrim

  • Authors zabrocki deleted
  • Milestone changed from sage-5.11 to sage-duplicate/invalid/wontfix
  • Reviewers set to Travis Scrimshaw
  • Status changed from new to needs_review

Just double check that everything is done in #14101, I think I ended up taking care of all of it in there. (I hope you haven't done any work on this Mike; sorry if you have.)

comment:2 Changed 8 years ago by zabrocki

  • Status changed from needs_review to needs_work

This covers .pp() but doesn't cover latex, or display. Are you planning on adding those to #14101?

comment:3 Changed 8 years ago by tscrim

  • Dependencies set to #14101
  • Status changed from needs_work to needs_review

They are done in (the latest version of) #14101:

sage: S = SkewTableau([[None, None, 3], [1, 2, 4], [5]]) 
sage: S
[[None, None, 3], [1, 2, 4], [5]]
sage: S.pp()
  .  .  3
  1  2  4
  5
sage: SkewTableaux.global_options(convention="French")
sage: S.pp()
  5
  1  2  4
  .  .  3
sage: SkewTableaux.global_options(display="diagram")
sage: S
  5
  1  2  4
  .  .  3
sage: latex(S) # If you can parse this, you'll see it's in French notation
{\def\lr#1{\multicolumn{1}{|@{\hspace{.6ex}}c@{\hspace{.6ex}}|}{\raisebox{-.3ex}{$#1$}}}
\raisebox{-.6ex}{$\begin{array}[t]{*{3}c}\cline{1-1}
\lr{5}\\\cline{1-3}
\lr{1}&\lr{2}&\lr{4}\\\cline{1-3}
&&\lr{3}\\\cline{3-3}
\end{array}$}
}
Last edited 8 years ago by tscrim (previous) (diff)

comment:4 Changed 8 years ago by zabrocki

I'm a little confused about what options are set where.

sage: SkewTableaux.global_options(latex="list")
...
ValueError: latex is not an option for skew tableaux

gives a traceback error.

That should read "list is not an option ..."

sage: Tableaux.global_options(display="diagram")
sage: SkewTableau([[None,1],[2]])
[[None, 1], [2]]
sage: SkewTableaux.global_options(display="diagram")
sage: SkewTableau([[None,1],[2]])
  .  1
  2
sage: SkewTableaux.global_options(display="compact")
...
ValueError: compact is not a valid value for display in the options for skew tableaux

I wouldn't know to look for the global options in SkewTableaux to set the diagram display given that "convention" and "latex" options can be set in Tableaux.global_options

Shouldn't they consistently follow a single global options?

Last edited 8 years ago by zabrocki (previous) (diff)

comment:5 Changed 8 years ago by tscrim

Ah, you're right. They should be much more constistant than they are. Will fix #14101.

comment:6 Changed 8 years ago by tscrim

Alright they are now the same global options in #14101. I believe we can close this ticket as a duplicate (and any other problems can be posted on #14101).

comment:7 Changed 8 years ago by tscrim

Hey Mike,

Is everything that you'd want done taken care of in #14101? If so, we should set this to positive review.

Best,
Travis

comment:8 Changed 8 years ago by zabrocki

  • Status changed from needs_review to positive_review

Yes. We can close this ticket. #14101 does a lot more than I expected for this patch. Thanks for doing all that.

-Mike

comment:9 Changed 8 years ago by tscrim

Your welcome,
Travis

comment:10 Changed 8 years ago by jdemeyer

  • Resolution set to duplicate
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.