Opened 9 years ago
Last modified 22 months ago
#14756 new enhancement
The StollCremona reduction method for hyperelliptic curves over number fields
Reported by:  Marco Streng  Owned by:  William Stein 

Priority:  major  Milestone:  sage6.4 
Component:  number theory  Keywords:  mestre algorithm genus 2 hyperelliptic curves sd35 sd51 
Cc:  Florian Bouyer  Merged in:  
Authors:  Florian Bouyer, Marco Streng  Reviewers:  
Report Upstream:  N/A  Work issues:  
Branch:  u/fstromberg/ticket/14756 (Commits, GitHub, GitLab)  Commit:  54cf573aebc72472a284836ce5139a9d70118e64 
Dependencies:  #14977, #14978  Stopgaps: 
Description (last modified by )
* latest version is in the git branch *
Implement the SL_2(O_K) reduction method for hyperelliptic curves over numbers fields from StollCremona  On the reduction theory of binary forms, J. Reine Angew. Math. 565 (2003), 79–99.
See also
 The intended SageMath code, but as a separate package.
 #21248  Case K=QQ
 #14755  also about reduction of hyperelliptic curve equations, depends on this ticket
 #14978  fundamental domains for Hilbert modular groups
 #14977  Hilbert modular groups
Attachments (1)
Change History (15)
Changed 9 years ago by
Attachment:  14756screduction.patch added 

comment:1 Changed 9 years ago by
Authors:  → Florian Bouyer, Marco Streng 

Cc:  Florian Bouyer added 
Description:  modified (diff) 
comment:2 Changed 9 years ago by
Keywords:  mestre algorithm genus 2 hyperelliptic curves sd35 sd51 added 

comment:3 Changed 9 years ago by
Branch:  → u/fstromberg/ticket/14756 

comment:4 Changed 9 years ago by
Dependencies:  → #14482 

comment:5 Changed 9 years ago by
Dependencies:  #14482 

comment:7 Changed 9 years ago by
Milestone:  sage5.11 → sage5.12 

comment:8 followup: 9 Changed 9 years ago by
Please make it clear whether the patch or the git branch should be merged. In the latter case, change the milestone to sage6.0.
comment:9 Changed 9 years ago by
Description:  modified (diff) 

Replying to jdemeyer:
Please make it clear whether the patch or the git branch should be merged. In the latter case, change the milestone to sage6.0.
We are currently working with the git branch. But if this ticket is finished before the switch to git happens, then we can always manually create a new patch file with the differences, so I don't see the need of bumping it all the way to sage6.0.
comment:10 Changed 9 years ago by
Dependencies:  → #14977, #14978 

Description:  modified (diff) 
comment:11 Changed 9 years ago by
Milestone:  sage6.1 → sage6.2 

comment:12 Changed 8 years ago by
Milestone:  sage6.2 → sage6.3 

comment:13 Changed 8 years ago by
Milestone:  sage6.3 → sage6.4 

comment:14 Changed 22 months ago by
Commit:  → 54cf573aebc72472a284836ce5139a9d70118e64 

Description:  modified (diff) 
We were too ambitious in trying to put the general case over number fields in there all at once. In the mean time, others managed to put the case of QQ in SageMath, so if we ever continue with this ticket, then we should also take into account #21248.
Last 10 new commits:
004b333  Merge branch 'ticket/14977' into ticket/14756

4f3ac71  Fixed usage of the new structure

887cdea  Added the files and made appropriate changes to the hilbert modular group class

6bb2f07  added import by QQ

9cdb4c3  added import of QQ

7e11ee4  Merge branch 'ticket/14977' into ticket/14978

624330a  Merge branch 'ticket/14978' into ticket/14756

635caeb  fixed small bug, changing s to z

22e160c  Merge branch 'ticket/14978' into ticket/14756

54cf573  Fixed small bug. The rest of the doctests are still failing

I took out routines dealing with fundamental domains and reduction and inserted them into tickets 14977 and 14978. There are doctests to be fixed.