Opened 6 years ago

Closed 6 years ago

#14721 closed defect (fixed)

Disable "cythonizing out-of-tree" until sage-sync-build and sage-clone can deal with that

Reported by: leif Owned by: GeorgSWeber
Priority: blocker Milestone: sage-5.10
Component: build Keywords: useless rebuild library build_dir
Cc: Merged in: sage-5.10.rc2
Authors: Leif Leonhardy Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by leif)

See #13245 and the sage-devel thread on useless rebuilding of the Sage library ...

The patch effectively reverts the change to setup.py made by ticket:14570:trac14570.patch​ (btw. the only functional change of that patch).

Apply: trac_14721-postpone_cythonizing_out_of_tree.sagelib.patch​

Attachments (1)

trac_14721-postpone_cythonizing_out_of_tree.sagelib.patch​ (788 bytes) - added by leif 6 years ago.
Apply to the Sage library. Based on Sage 5.10.rc1.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 6 years ago by leif

  • Keywords useless rebuild library build_dir added

Changed 6 years ago by leif

Apply to the Sage library. Based on Sage 5.10.rc1.

comment:2 Changed 6 years ago by leif

  • Description modified (diff)
  • Status changed from new to needs_review

comment:3 follow-up: Changed 6 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

This worked for me (with possibly #13245).

Edit wrt comment:5 - Yes I did

Last edited 6 years ago by tscrim (previous) (diff)

comment:4 Changed 6 years ago by tscrim

Thanks for looking into this Leif.

comment:5 in reply to: ↑ 3 Changed 6 years ago by leif

Replying to tscrim:

This worked for me (with possibly #13425).

I guess you meant #13245.

comment:6 Changed 6 years ago by leif

  • Description modified (diff)

comment:7 Changed 6 years ago by jdemeyer

  • Merged in set to sage-5.10.rc2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.