Changes between Version 117 and Version 118 of Ticket #14711


Ignore:
Timestamp:
10/07/13 11:25:40 (6 years ago)
Author:
SimonKing
Comment:

I think changing the string representation of weakened maps should be done here. And then, in a couple of tests, one needs to copy the map in order to get the test pass.

Therefore, I suggest to implement copying for all maps here as well, not on a different ticket. After all, it is not difficult: One just looks at the list of cdef attributes, and implements _extra_slots and _update_slots taking exactly these attributes into account. The only difficulty is to really catch all kinds of maps.

Note that in most cases phi == loads(dumps(phi)) would return False, but this is since comparison of maps is often not implemented---and this is what I will certainly not attempt to implement here.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #14711

    • Property Status changed from needs_review to needs_work
    • Property Work issues changed from to String repr. of weakened maps; copying/pickling of maps
  • Ticket #14711 – Description

    v117 v118  
    7474'''__Still TODO__'''
    7575
    76 Let the string representation of weakened maps point the user to the need of
     76- Let the string representation of weakened maps point the user to the need of
    7777creating a copy.
     78- Provide copying for ''all'' kinds of maps.
    7879
    7980'''__TODO in future tickets__'''
     
    8687  `._coerce_map_from_()`, but of course `._coerce_map_from()` could not easily
    8788  be changed in an interactive session.
    88 - provide copying for ''all'' kinds of maps.
    8989
    9090'''__Effects on the overall functioning of Sage__'''