Opened 6 years ago
Closed 6 years ago
#14710 closed enhancement (fixed)
Update boehm_gc to 7.2d
| Reported by: | jpflori | Owned by: | jdemeyer |
|---|---|---|---|
| Priority: | major | Milestone: | sage-5.13 |
| Component: | packages: standard | Keywords: | spkg boehm_gc |
| Cc: | kcrisman, dimpase, jdemeyer, tscrim | Merged in: | sage-5.13.beta2 |
| Authors: | Jean-Pierre Flori | Reviewers: | Dmitrii Pasechnik, Jeroen Demeyer |
| Report Upstream: | N/A | Work issues: | |
| Branch: | Commit: | ||
| Dependencies: | Stopgaps: |
Description (last modified by )
We are currently packaging some alpha version.
Moreover it would be a good time to:
- cleanup the spkg scripts,
- add a patch from Cygwin folks to build on Cygwin64 (see source package),
- remove the Cygwin threads workaround (I don't need it to build on Cygwin64, did not test Cygwin, it seems though threaded libgc might be harmful on Cygwin but it was not the reason of the workaround which was only set up to let libgc build).
Use spkg at:
Attachments (1)
Change History (20)
comment:1 Changed 6 years ago by
- Cc jdmeyer added
- Description modified (diff)
- Keywords spkg boehm_gc added
- Status changed from new to needs_review
comment:2 Changed 6 years ago by
- Dependencies set to #14715
comment:3 Changed 6 years ago by
Why the dependency on #14715?
comment:4 follow-up: ↓ 5 Changed 6 years ago by
Because I removed some RM related stuff.
comment:5 in reply to: ↑ 4 Changed 6 years ago by
Replying to jpflori:
Because I removed some RM related stuff.
Which is related to this ticket because ............. ?
comment:6 Changed 6 years ago by
- Dependencies #14715 deleted
comment:7 Changed 6 years ago by
Because it was needed to upgrade from Sage <= 4.7.
comment:8 Changed 6 years ago by
Not anymore, the RM which is deleted in #14715 makes sure upgrades from older versions work. The unset RM in boehm_gc and the RM stuff in spkg/install have the same purpose.
comment:9 Changed 6 years ago by
- Cc jdemeyer tscrim added; jdmeyer removed
comment:10 Changed 6 years ago by
- Milestone changed from sage-5.11 to sage-5.12
comment:11 Changed 6 years ago by
Anyone for this simple update?
It's basically updating boehm_gc to a stable version, removing patches which went upstream and adding a ptach from the cygwin folk.
comment:12 Changed 6 years ago by
looks good, but I can't test on Cygwin presently.
comment:13 Changed 6 years ago by
- Status changed from needs_review to positive_review
comment:14 Changed 6 years ago by
- Status changed from positive_review to needs_info
What's your justification for
patch -p1 <"$patch" || continue
(especially the continue in spkg-install)?
Also, Reviewer should be filled in.
comment:15 Changed 6 years ago by
| continue I guess. |
The -p0 to -p1 is just because the cd src moved because I wanted the script to look more like other scriptS.
comment:16 Changed 6 years ago by
- Status changed from needs_info to needs_work
- Work issues set to patching commands
comment:17 Changed 6 years ago by
- Reviewers set to Dmitrii Pasechnik, Jeroen Demeyer
- Status changed from needs_work to needs_review
- Work issues patching commands deleted
I indeed screwed up between testing the spkg on cygwin and packqging it later... Should be ok now.
comment:18 Changed 6 years ago by
- Status changed from needs_review to positive_review
OK, looks that things are fixed, and work, too.
comment:19 Changed 6 years ago by
- Merged in set to sage-5.13.beta2
- Resolution set to fixed
- Status changed from positive_review to closed
I've removed the two OS X patches (needed before on OS X 10.7) as it seems the relevant part is now upstream. This needs testing.
Added a patch for Cygwin64, works ok.
Also removed the thread hack, it builds without it, not sure it can break something further.