Opened 6 years ago

Closed 6 years ago

#14710 closed enhancement (fixed)

Update boehm_gc to 7.2d

Reported by: jpflori Owned by: jdemeyer
Priority: major Milestone: sage-5.13
Component: packages: standard Keywords: spkg boehm_gc
Cc: kcrisman, dimpase, jdemeyer, tscrim Merged in: sage-5.13.beta2
Authors: Jean-Pierre Flori Reviewers: Dmitrii Pasechnik, Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by jpflori)

We are currently packaging some alpha version.

Moreover it would be a good time to:

  • cleanup the spkg scripts,
  • add a patch from Cygwin folks to build on Cygwin64 (see source package),
  • remove the Cygwin threads workaround (I don't need it to build on Cygwin64, did not test Cygwin, it seems though threaded libgc might be harmful on Cygwin but it was not the reason of the workaround which was only set up to let libgc build).

Use spkg at:

Attachments (1)

boehm_gc-7.2d.p0.diff (10.9 KB) - added by jpflori 6 years ago.
Spkg diff, for review only.

Download all attachments as: .zip

Change History (20)

comment:1 Changed 6 years ago by jpflori

  • Authors set to Jean-Pierre Flori
  • Cc jdmeyer added
  • Description modified (diff)
  • Keywords spkg boehm_gc added
  • Status changed from new to needs_review

I've removed the two OS X patches (needed before on OS X 10.7) as it seems the relevant part is now upstream. This needs testing.

Added a patch for Cygwin64, works ok.

Also removed the thread hack, it builds without it, not sure it can break something further.

comment:2 Changed 6 years ago by jpflori

  • Dependencies set to #14715

comment:3 Changed 6 years ago by jdemeyer

Why the dependency on #14715?

comment:4 follow-up: Changed 6 years ago by jpflori

Because I removed some RM related stuff.

comment:5 in reply to: ↑ 4 Changed 6 years ago by jdemeyer

Replying to jpflori:

Because I removed some RM related stuff.

Which is related to this ticket because ............. ?

comment:6 Changed 6 years ago by jdemeyer

  • Dependencies #14715 deleted

comment:7 Changed 6 years ago by jpflori

Because it was needed to upgrade from Sage <= 4.7.

comment:8 Changed 6 years ago by jdemeyer

Not anymore, the RM which is deleted in #14715 makes sure upgrades from older versions work. The unset RM in boehm_gc and the RM stuff in spkg/install have the same purpose.

comment:9 Changed 6 years ago by jpflori

  • Cc jdemeyer tscrim added; jdmeyer removed

comment:10 Changed 6 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:11 Changed 6 years ago by jpflori

Anyone for this simple update?

It's basically updating boehm_gc to a stable version, removing patches which went upstream and adding a ptach from the cygwin folk.

comment:12 Changed 6 years ago by dimpase

looks good, but I can't test on Cygwin presently.

comment:13 Changed 6 years ago by dimpase

  • Status changed from needs_review to positive_review

comment:14 Changed 6 years ago by jdemeyer

  • Status changed from positive_review to needs_info

What's your justification for

patch -p1 <"$patch" || continue

(especially the continue in spkg-install)?

Also, Reviewer should be filled in.

comment:15 Changed 6 years ago by jpflori

None the continue is wrong, I wanted something like [ -r $patch ]
continue I guess.

The -p0 to -p1 is just because the cd src moved because I wanted the script to look more like other scriptS.

comment:16 Changed 6 years ago by jpflori

  • Status changed from needs_info to needs_work
  • Work issues set to patching commands

comment:17 Changed 6 years ago by jpflori

  • Reviewers set to Dmitrii Pasechnik, Jeroen Demeyer
  • Status changed from needs_work to needs_review
  • Work issues patching commands deleted

I indeed screwed up between testing the spkg on cygwin and packqging it later... Should be ok now.

Changed 6 years ago by jpflori

Spkg diff, for review only.

comment:18 Changed 6 years ago by dimpase

  • Status changed from needs_review to positive_review

OK, looks that things are fixed, and work, too.

comment:19 Changed 6 years ago by jdemeyer

  • Merged in set to sage-5.13.beta2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.