Opened 9 years ago

Closed 9 years ago

#14701 closed enhancement (fixed)

Delsarte's formula for counting the number of subgroups of an abelian p-group of a given type

Reported by: Amritanshu Prasad Owned by: Sage Combinat CC user
Priority: minor Milestone: sage-5.11
Component: combinatorics Keywords: q_analogues, finite-abelian-group
Cc: Merged in: sage-5.11.beta2
Authors: Amritanshu Prasad Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

Delsarte's formula to compute (as a formal polynomial in q) the number of subgroups of type mu in a finite abelian q-group of type la, where mu and la are partitions.

Attachments (3)

18218.patch (3.2 KB) - added by Amritanshu Prasad 9 years ago.
trac_14701-review-ts.patch (6.0 KB) - added by Travis Scrimshaw 9 years ago.
18387.patch (708 bytes) - added by Amritanshu Prasad 9 years ago.
corrected spacing in one failing doctest

Download all attachments as: .zip

Change History (9)

Changed 9 years ago by Amritanshu Prasad

Attachment: 18218.patch added

comment:1 Changed 9 years ago by Amritanshu Prasad

Status: newneeds_review

Changed 9 years ago by Travis Scrimshaw

Attachment: trac_14701-review-ts.patch added

comment:2 Changed 9 years ago by Travis Scrimshaw

Hey Amri,

Here's a review patch which does the following:

  • Uses ** instead of ^ since in python (which all .py files get interpreted as) the latter means bitwise-xor.
  • Makes some simplifications to your code by using the prod function instead of reduce.
  • Expands on the docstrings and changes them around for some formatting and default latex macros for sage.

If you're happy with my changes, you can go ahead and set this to positive review. Feel free to ask me any questions if you have any.

Best,
Travis

Changed 9 years ago by Amritanshu Prasad

Attachment: 18387.patch added

corrected spacing in one failing doctest

comment:3 in reply to:  2 Changed 9 years ago by Amritanshu Prasad

Dear Travis,

Thanks for the corrections; there was just one doctest that failed because of wrong spacing. I have corrected that, and I think this is ok now.

Amri.

Replying to tscrim:

Hey Amri,

Here's a review patch which does the following:

  • Uses ** instead of ^ since in python (which all .py files get interpreted as) the latter means bitwise-xor.
  • Makes some simplifications to your code by using the prod function instead of reduce.
  • Expands on the docstrings and changes them around for some formatting and default latex macros for sage.

If you're happy with my changes, you can go ahead and set this to positive review. Feel free to ask me any questions if you have any.

Best,
Travis

comment:4 Changed 9 years ago by Amritanshu Prasad

Status: needs_reviewpositive_review

comment:5 Changed 9 years ago by Jeroen Demeyer

Reviewers: Travis Scrimshaw

comment:6 Changed 9 years ago by Jeroen Demeyer

Merged in: sage-5.11.beta2
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.