Opened 9 years ago
Closed 9 years ago
#14701 closed enhancement (fixed)
Delsarte's formula for counting the number of subgroups of an abelian p-group of a given type
Reported by: | Amritanshu Prasad | Owned by: | Sage Combinat CC user |
---|---|---|---|
Priority: | minor | Milestone: | sage-5.11 |
Component: | combinatorics | Keywords: | q_analogues, finite-abelian-group |
Cc: | Merged in: | sage-5.11.beta2 | |
Authors: | Amritanshu Prasad | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
Delsarte's formula to compute (as a formal polynomial in q) the number of subgroups of type mu in a finite abelian q-group of type la, where mu and la are partitions.
Attachments (3)
Change History (9)
Changed 9 years ago by
Attachment: | 18218.patch added |
---|
comment:1 Changed 9 years ago by
Status: | new → needs_review |
---|
Changed 9 years ago by
Attachment: | trac_14701-review-ts.patch added |
---|
comment:2 follow-up: 3 Changed 9 years ago by
comment:3 Changed 9 years ago by
Dear Travis,
Thanks for the corrections; there was just one doctest that failed because of wrong spacing. I have corrected that, and I think this is ok now.
Amri.
Replying to tscrim:
Hey Amri,
Here's a review patch which does the following:
- Uses
**
instead of^
since in python (which all.py
files get interpreted as) the latter means bitwise-xor.- Makes some simplifications to your code by using the
prod
function instead ofreduce
.- Expands on the docstrings and changes them around for some formatting and default latex macros for sage.
If you're happy with my changes, you can go ahead and set this to positive review. Feel free to ask me any questions if you have any.
Best,
Travis
comment:4 Changed 9 years ago by
Status: | needs_review → positive_review |
---|
comment:5 Changed 9 years ago by
Reviewers: | → Travis Scrimshaw |
---|
comment:6 Changed 9 years ago by
Merged in: | → sage-5.11.beta2 |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
Hey Amri,
Here's a review patch which does the following:
**
instead of^
since in python (which all.py
files get interpreted as) the latter means bitwise-xor.prod
function instead ofreduce
.If you're happy with my changes, you can go ahead and set this to positive review. Feel free to ask me any questions if you have any.
Best,
Travis