Opened 6 years ago

Closed 6 years ago

#14696 closed defect (fixed)

Mistake in the doc of Steiner Quadruple Systems

Reported by: ncohen Owned by: mvngu
Priority: major Milestone: sage-5.11
Component: documentation Keywords:
Cc: vbraun Merged in: sage-5.11.rc0
Authors: Nathann Cohen Reviewers: Punarbasu Purkayastha
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

Gloops.... The mistake is just in the doc, not in the code ! The function designs.steiner_quadruple_system checks that the system exist for all integers n equal to 2 or 4 mod 6 ^^;

Nathann

Attachments (1)

trac_14696.patch (4.5 KB) - added by ncohen 6 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 6 years ago by ncohen

  • Status changed from new to needs_review

comment:2 Changed 6 years ago by ppurka

More work for you: the file is littered with stuff written like 2,4 [12]. I think it should be written as 2,4 \mod 12 since it is going to be rendered in latex. I haven't seen this notation a [b] to denote a mod b before.

comment:3 Changed 6 years ago by vbraun

I've seen that with round brackets, usually the mod is spelled out as a \equiv b (mod c) but sometimes people abbreviate it to a \equiv b (c). Maybe square brackets are a French thing?

comment:4 Changed 6 years ago by ncohen

Patch updated !

I went into Florent's office and asked him if he had ever used this bracket notation, and he told me that he rarely if ever used it. That he mostly saw \pmod everywhere.

And I am almost sure that I never wrote "mod" of my whole life, and always used these brackets.. In lectures, in exams, everywhere :-P

Soooooooooooooo maybe I'm mad, but I still updated the patch. I also renamed an "height" into a "eight", because I am an idiot.

Turns out that this review was more complicated than expected :-D

Nathann

comment:5 Changed 6 years ago by ppurka

One typo: the first mod should be \pmod.

267	    `n \equiv 1 mod 6` or `n \equiv 3 \pmod 6`, in which case

Turns out that this review was more complicated than expected :-D

Yes, that's the problem with the old code in sage. If you touch at one place, you have to touch it at many places. ;)

comment:6 Changed 6 years ago by ncohen

Donnnnneeeeeeee !!

Nathann

Changed 6 years ago by ncohen

comment:7 Changed 6 years ago by ppurka

  • Reviewers set to Punarbasu Purkayastha
  • Status changed from needs_review to positive_review

Great! Looks good to me. Thanks :)

comment:8 Changed 6 years ago by ncohen

Thanks for the review ! And I owe you one :-)

Nathann

comment:9 Changed 6 years ago by jdemeyer

  • Merged in set to sage-5.11.rc0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.