Opened 8 years ago

Last modified 6 years ago

#14686 needs_info enhancement

More crystals speedups

Reported by: tscrim Owned by: sage-combinat
Priority: major Milestone: sage-6.4
Component: combinatorics Keywords: crystals speedup optimization
Cc: sage-combinat, bsalisbury1, aschilling, nthiery Merged in:
Authors: Travis Scrimshaw Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #14516 #14573 #14143 Stopgaps:

Description

Followup to #14516 which does the following:

  • Instead of e(), f(), epsilon(), phi() checking the index set each time, these functions will check to make sure i is in the index set, then call _e(), _f(), _epsilon(), _phi() which assume i is valid input and respectively call the private methods.

Attachments (1)

trac_14686-crystals_speedup_functions-ts.patch​ (112.0 KB) - added by tscrim 8 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 8 years ago by tscrim

  • Dependencies changed from #14516 to #14516 #14573

comment:2 Changed 8 years ago by tscrim

  • Dependencies changed from #14516 #14573 to #14516 #14573 #14143
  • Status changed from new to needs_review

Changed 8 years ago by tscrim

comment:3 Changed 8 years ago by tscrim

  • Status changed from needs_review to needs_info

Until we decide on an approach to handle checks on user inputs only.

comment:4 Changed 7 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:5 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:6 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:7 Changed 6 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4
Note: See TracTickets for help on using tickets.