Changes between Initial Version and Version 1 of Ticket #14666, comment 41


Ignore:
Timestamp:
05/11/16 23:31:21 (19 months ago)
Author:
tara
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #14666, comment 41

    initial v1  
    11The only thing that looks like a problem is in edb1a33, you changed `wt = sorted(wt, reverse=True)` to `wt = sorted(wt)` in line 6667. And later changed `if wt_dic[e] < wt_dic[res[-1]]:` to `if wt_dic[e] > wt_dic[res[-1]]:`. It seems like this would test if a minimum cobasis was generic rather than a maximum cobasis. I would expect `M.is_max_weight_coindependent_generic()` to give the same results as `M*.is_max_weight_independent_generic()`, where `M*` is the dual of `M`.
     2
     3My "we" sometimes included Stefan. He and I are both at LSU, and he's given recommendations. He might have avoided writing code so that he would be free to review it.