Opened 6 years ago

Closed 6 years ago

#14649 closed defect (fixed)

Cython debug symbols and sage --gdb

Reported by: vbraun Owned by: GeorgSWeber
Priority: blocker Milestone: sage-5.10
Component: build Keywords:
Cc: jdemeyer, roed, ohanar, ppurka, kini, mhansen, leif Merged in: sage-5.10.rc1
Authors: Volker Braun Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by vbraun)

Debugging got broken by #13031.

Apply

Attachments (2)

trac_14649_root_cython_debug.patch (694 bytes) - added by vbraun 6 years ago.
Initial patch
trac_14649_cython_debug.patch (1.7 KB) - added by vbraun 6 years ago.
Updated patch

Download all attachments as: .zip

Change History (11)

Changed 6 years ago by vbraun

Initial patch

comment:1 Changed 6 years ago by vbraun

  • Authors set to Volker Braun
  • Description modified (diff)

comment:2 Changed 6 years ago by vbraun

  • Cc jdemeyer roed ohanar ppurka kini mhansen added
  • Status changed from new to needs_review

comment:3 follow-up: Changed 6 years ago by jdemeyer

The doctest should be

# optional - gdb

Changed 6 years ago by vbraun

Updated patch

comment:4 in reply to: ↑ 3 Changed 6 years ago by vbraun

Replying to jdemeyer:

# optional - gdb

Done.

comment:5 follow-up: Changed 6 years ago by ppurka

Shouldn't the default value here be 'yes'?

    if os.environ.get('SAGE_DEBUG', None) != 'no':

I don't think it is recommended to compare None with equality operators.

comment:6 in reply to: ↑ 5 Changed 6 years ago by vbraun

Replying to ppurka:

Shouldn't the default value here be 'yes'?

No, see #13881

comment:7 Changed 6 years ago by leif

  • Cc leif added

comment:8 Changed 6 years ago by vbraun

  • Priority changed from major to blocker

I think this should be a blocker for sage-5.10. Shipping with broken --gdb just makes debugging needlessly complicated.

comment:9 Changed 6 years ago by jdemeyer

  • Merged in set to sage-5.10.rc1
  • Resolution set to fixed
  • Reviewers set to Jeroen Demeyer
  • Status changed from needs_review to closed
Note: See TracTickets for help on using tickets.