Opened 6 years ago

Closed 6 years ago

#14647 closed defect (fixed)

Update iconv to version 1.14

Reported by: jpflori Owned by: jdemeyer
Priority: major Milestone: sage-5.11
Component: packages: standard Keywords: iconv spkg cygwin cygwin64
Cc: kcrisman, dimpase Merged in: sage-5.11.beta0
Authors: Jean-Pierre Flori Reviewers: Leif Leonhardy
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by jpflori)

It has been out for some time and fixes the use of an obsolete function "cygwin_conv_to_posix_path" on Cygwin (32 bits) and unavailable on Cygwin64.

Use spkg at:

Attachments (1)

iconv-1.14.diff​ (322 bytes) - added by jpflori 6 years ago.
Spkg diff, for review only.

Download all attachments as: .zip

Change History (17)

Changed 6 years ago by jpflori

Spkg diff, for review only.

comment:1 Changed 6 years ago by jpflori

  • Description modified (diff)
  • Status changed from new to needs_review

comment:2 Changed 6 years ago by jpflori

  • Authors set to Jean-Pierre Flori
  • Keywords iconv spkg cygwin added

comment:3 Changed 6 years ago by jpflori

  • Cc kcrisman dimpase added

comment:4 Changed 6 years ago by leif

  • Description modified (diff)

unable to resolve host address “boxen.math.washingotn.edu”

comment:5 Changed 6 years ago by jpflori

Indeed, thanks. I only tested it builds on Cygwin64, not on anything else yet. Note there are only few platforms where this is actually built.

comment:6 Changed 6 years ago by jpflori

  • Keywords cygwin64 added

comment:7 follow-up: Changed 6 years ago by leif

Currently building on Solaris SPARC.

HP-UX, anyone? ;-)

comment:8 Changed 6 years ago by jpflori

  • Description modified (diff)

Builds ok on Solaris 10 on ultrasparc T2+.

comment:9 in reply to: ↑ 7 ; follow-up: Changed 6 years ago by leif

Replying to leif:

Currently building on Solaris SPARC.

Succeeded with SAGE_CHECK=yes on SunOS 5.10 UltraSPARC III (ABI=32) with GCC 4.7.0 as well as GCC 4.7.2, modulo the usual expected three segfaults: 

./check-subst
Segmentation Fault - core dumped
Segmentation Fault - core dumped
Segmentation Fault - core dumped

I haven't rebuilt anything depending on iconv though.

comment:10 in reply to: ↑ 9 ; follow-up: Changed 6 years ago by jpflori

Replying to leif:

Replying to leif:

Currently building on Solaris SPARC.

Succeeded with SAGE_CHECK=yes on SunOS 5.10 UltraSPARC III (ABI=32) with GCC 4.7.0 as well as GCC 4.7.2, modulo the usual expected three segfaults: 

./check-subst
Segmentation Fault - core dumped
Segmentation Fault - core dumped
Segmentation Fault - core dumped

I haven't rebuilt anything depending on iconv though.

Is that documented somewhere?

And any chance for review? :)

comment:11 Changed 6 years ago by jdemeyer

I might give a review, but it's not a high-priority for me.

comment:12 in reply to: ↑ 10 Changed 6 years ago by leif

Replying to jpflori:

Replying to leif:

Replying to leif:

Currently building on Solaris SPARC.

Succeeded with SAGE_CHECK=yes on SunOS 5.10 UltraSPARC III (ABI=32) with GCC 4.7.0 as well as GCC 4.7.2, modulo the usual expected three segfaults: 

./check-subst
Segmentation Fault - core dumped
Segmentation Fault - core dumped
Segmentation Fault - core dumped

I haven't rebuilt anything depending on iconv though.

IIRC I at least successfully rebuilt MPIR (which depends on iconv) afterwards.


Is that documented somewhere?

Yes.


And any chance for review? :)

Just a matter of time (and my ability to keep this ticket in mind).

comment:13 Changed 6 years ago by leif

  • Reviewers set to Leif Leonhardy
  • Status changed from needs_review to positive_review

Slight modifications to spkg-install and spkg-check may be possible, but since you didn't touch them at all ...

Assuming you've successfully tested it on Cygwin![64], positive review.


Out of curiosity, how does Cygwin64 identify itself (uname, Sage's $UNAME)?

comment:14 Changed 6 years ago by jpflori

On Cygwin: 

$ uname -a
CYGWIN_NT-6.1-WOW64 napoleon-7 1.7.18(0.263/5/3) 2013-04-19 10:39 i686 Cygwin

On Cygwin64: 

$ uname -a
CYGWIN_NT-6.1 napoleon-7 1.7.19(0.266/5/3) 2013-05-24 23:18 x86_64 Cygwin

comment:15 Changed 6 years ago by jdemeyer

  • Milestone changed from sage-5.10 to sage-5.11

comment:16 Changed 6 years ago by jdemeyer

  • Merged in set to sage-5.11.beta0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.