Opened 8 years ago

Closed 8 years ago

#14612 closed defect (fixed)

Speedup long test in generalized Young walls

Reported by: tscrim Owned by: sage-combinat
Priority: blocker Milestone: sage-5.10
Component: doctest coverage Keywords: doctest time
Cc: sage-combinat, jdemeyer, aschilling Merged in: sage-5.10.beta5
Authors: Travis Scrimshaw Reviewers: Anne Schilling
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by aschilling)

One test in #14454 takes about 203 seconds. By removing some of the test cases, this was reduced.

Attachments (1)

trac_14612-gyw_test_speedup-ts.patch (1.1 KB) - added by tscrim 8 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 follow-up: Changed 8 years ago by tscrim

  • Status changed from new to needs_review

I skipped the two longest tests in the TestSuite since they require a significant iteration over the crystal.

sage: %time TestSuite(YLa).run(skip=["_test_enumerated_set_contains","_test_stembridge_local_axioms"])
CPU times: user 2.26 s, sys: 0.01 s, total: 2.27 s
Wall time: 2.53 s

comment:2 in reply to: ↑ 1 Changed 8 years ago by aschilling

Hi Travis,

Thanks for figuring this out. But why is this a new ticket and not a fix to http://trac.sagemath.org/sage_trac/ticket/14454 ?

Anne

comment:3 Changed 8 years ago by tscrim

Because #14454 is already closed, I thought a new ticket was the proper procedure.

comment:4 Changed 8 years ago by jdemeyer

  • Component changed from performance to doctest coverage
  • Priority changed from critical to blocker
  • Type changed from enhancement to defect

comment:5 Changed 8 years ago by jdemeyer

The new test should still be marked # long time if it takes more than 1 second (on sage.math)

Changed 8 years ago by tscrim

comment:6 Changed 8 years ago by tscrim

Kept it as # long time.

comment:7 Changed 8 years ago by aschilling

  • Description modified (diff)
  • Reviewers set to Anne Schilling
  • Status changed from needs_review to positive_review

comment:8 Changed 8 years ago by jdemeyer

Thanks for taking care of this.

comment:9 Changed 8 years ago by jdemeyer

  • Merged in set to sage-5.10.beta5
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.