Opened 7 years ago

Closed 6 years ago

#14605 closed enhancement (fixed)

Better system detection for ATLAS

Reported by: jpflori Owned by: jdemeyer
Priority: major Milestone: sage-6.2
Component: packages: standard Keywords: atlas, days57
Cc: leif Merged in:
Authors: Jean-Pierre Flori Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: 3f1defb (Commits) Commit: 3f1defbe9f2e4affd39fa64673341039267900c1
Dependencies: #14699 Stopgaps:

Description (last modified by jpflori)

See lots of rants in #10508.

This fixes a bunch of problems with ATLAS detection system. Adds support for (some) ARM hard float systems. Adds archdefs for Raspberry Pi and Cygwin64.

Use tarball at:

Attachments (1)

atlas-3.10.1.p1.diff (14.2 KB) - added by jpflori 7 years ago.
Spkg diff, for review only.

Download all attachments as: .zip

Change History (25)

comment:1 Changed 7 years ago by leif

  • Cc leif added

comment:2 Changed 7 years ago by jpflori

  • Description modified (diff)

Preliminary spkg, please torture it but nothing is commited or documented, I'll try to do that over the week end but as it may not happen here is some stuff to test.

In particular it should (not tested!) work:

  • for non-threaded libraries anywhere, especially on computers with a single threaded unique core,
  • threaded on debian/sparc,
  • threaded on debian/powerpc,

whereas it used not to before. (I just remembered that "-t 0" is passed to configure in spkg-install so threads will always be disabled unless you change that.)

comment:3 Changed 7 years ago by vbraun

  • Authors set to Jean-Pierre Flori
  • Description modified (diff)

I fixed your url

Disabling threading unconditionally sucks big time on all modern hardware.

comment:4 Changed 7 years ago by jpflori

Thanks! I really uploaded that in a hurry. And it's not intended to always disable threading all the time in the final version. It is just what I was testing and forgot to comment again the "-t 0" line before uploading...

comment:5 Changed 7 years ago by jpflori

Should be fixed now.

comment:6 Changed 7 years ago by jpflori

  • Status changed from new to needs_review

Everything is commited now. If p0 of #10508 is integrated upstream and tagged in between, this might need a slight rebase.

comment:7 Changed 7 years ago by jpflori

Or we could just skip #10508...

comment:8 Changed 7 years ago by jpflori

nah, there are patches to the Sage library on #10508 so it's a bad idea to go too fast.

comment:9 Changed 7 years ago by jpflori

  • Status changed from needs_review to needs_work

And the new detect.patch did not get included in my latest spkg. Groumpf.

comment:10 Changed 7 years ago by jpflori

  • Status changed from needs_work to needs_review

Should be ok now.

comment:11 Changed 7 years ago by jpflori

  • Status changed from needs_review to needs_work

This still does not correctly detect cpu speed on debian sparc.

comment:12 Changed 7 years ago by jpflori

Ok, got it, my hex reading functions are broken.

comment:13 Changed 7 years ago by jpflori

  • Status changed from needs_work to needs_review

Should be fixed now.

Changed 7 years ago by jpflori

Spkg diff, for review only.

comment:15 Changed 7 years ago by jpflori

  • Dependencies set to #14605
  • Status changed from needs_review to needs_work
  • Work issues set to rebase

comment:16 Changed 7 years ago by jdemeyer

  • Dependencies changed from #14605 to #14699

comment:17 Changed 6 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:18 Changed 6 years ago by jpflori

Should be rebased on top of #14410. Also note that the most important patch from here was already merged into our spkg by Volker at some point IIRC.

comment:19 Changed 6 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:20 Changed 6 years ago by jpflori

  • Branch set to u/jpflori/ticket/14605
  • Commit set to 9d2673f4226a99868a8aa826d24b4f40ca15a089
  • Description modified (diff)
  • Keywords threads removed
  • Status changed from needs_work to needs_review
  • Summary changed from Fix thread related ATLAS problems to Better system detection for ATLAS
  • Work issues rebase deleted

New commits:

9d2673fBetter system detection for ATLAS.

comment:21 Changed 6 years ago by git

  • Commit changed from 9d2673f4226a99868a8aa826d24b4f40ca15a089 to 3f1defbe9f2e4affd39fa64673341039267900c1

Branch pushed to git repo; I updated commit sha1. New commits:

72e6977Merge remote-tracking branch 'trac/develop' into ticket/14605
3f1defbFix autotools optional spkg checksum spurious change.

comment:22 Changed 6 years ago by vbraun

  • Keywords days57 added
  • Reviewers set to Volker Braun

comment:23 Changed 6 years ago by vbraun

  • Status changed from needs_review to positive_review

lgtm

comment:24 Changed 6 years ago by vbraun

  • Branch changed from u/jpflori/ticket/14605 to 3f1defbe9f2e4affd39fa64673341039267900c1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.