Opened 10 years ago

Closed 9 years ago

#14605 closed enhancement (fixed)

Better system detection for ATLAS

Reported by: Jean-Pierre Flori Owned by: Jeroen Demeyer
Priority: major Milestone: sage-6.2
Component: packages: standard Keywords: atlas, days57
Cc: Leif Leonhardy Merged in:
Authors: Jean-Pierre Flori Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: 3f1defb (Commits, GitHub, GitLab) Commit: 3f1defbe9f2e4affd39fa64673341039267900c1
Dependencies: #14699 Stopgaps:

Status badges

Description (last modified by Jean-Pierre Flori)

See lots of rants in #10508.

This fixes a bunch of problems with ATLAS detection system. Adds support for (some) ARM hard float systems. Adds archdefs for Raspberry Pi and Cygwin64.

Use tarball at:

Attachments (1)

atlas-3.10.1.p1.diff (14.2 KB) - added by Jean-Pierre Flori 10 years ago.
Spkg diff, for review only.

Download all attachments as: .zip

Change History (25)

comment:1 Changed 10 years ago by Leif Leonhardy

Cc: Leif Leonhardy added

comment:2 Changed 10 years ago by Jean-Pierre Flori

Description: modified (diff)

Preliminary spkg, please torture it but nothing is commited or documented, I'll try to do that over the week end but as it may not happen here is some stuff to test.

In particular it should (not tested!) work:

  • for non-threaded libraries anywhere, especially on computers with a single threaded unique core,
  • threaded on debian/sparc,
  • threaded on debian/powerpc,

whereas it used not to before. (I just remembered that "-t 0" is passed to configure in spkg-install so threads will always be disabled unless you change that.)

comment:3 Changed 10 years ago by Volker Braun

Authors: Jean-Pierre Flori
Description: modified (diff)

I fixed your url

Disabling threading unconditionally sucks big time on all modern hardware.

comment:4 Changed 10 years ago by Jean-Pierre Flori

Thanks! I really uploaded that in a hurry. And it's not intended to always disable threading all the time in the final version. It is just what I was testing and forgot to comment again the "-t 0" line before uploading...

comment:5 Changed 10 years ago by Jean-Pierre Flori

Should be fixed now.

comment:6 Changed 10 years ago by Jean-Pierre Flori

Status: newneeds_review

Everything is commited now. If p0 of #10508 is integrated upstream and tagged in between, this might need a slight rebase.

comment:7 Changed 10 years ago by Jean-Pierre Flori

Or we could just skip #10508...

comment:8 Changed 10 years ago by Jean-Pierre Flori

nah, there are patches to the Sage library on #10508 so it's a bad idea to go too fast.

comment:9 Changed 10 years ago by Jean-Pierre Flori

Status: needs_reviewneeds_work

And the new detect.patch did not get included in my latest spkg. Groumpf.

comment:10 Changed 10 years ago by Jean-Pierre Flori

Status: needs_workneeds_review

Should be ok now.

comment:11 Changed 10 years ago by Jean-Pierre Flori

Status: needs_reviewneeds_work

This still does not correctly detect cpu speed on debian sparc.

comment:12 Changed 10 years ago by Jean-Pierre Flori

Ok, got it, my hex reading functions are broken.

comment:13 Changed 10 years ago by Jean-Pierre Flori

Status: needs_workneeds_review

Should be fixed now.

Changed 10 years ago by Jean-Pierre Flori

Attachment: atlas-3.10.1.p1.diff added

Spkg diff, for review only.

comment:14 Changed 10 years ago by Jean-Pierre Flori

comment:15 Changed 10 years ago by Jean-Pierre Flori

Dependencies: #14605
Status: needs_reviewneeds_work
Work issues: rebase

comment:16 Changed 10 years ago by Jeroen Demeyer

Dependencies: #14605#14699

comment:17 Changed 9 years ago by Jeroen Demeyer

Milestone: sage-5.11sage-5.12

comment:18 Changed 9 years ago by Jean-Pierre Flori

Should be rebased on top of #14410. Also note that the most important patch from here was already merged into our spkg by Volker at some point IIRC.

comment:19 Changed 9 years ago by For batch modifications

Milestone: sage-6.1sage-6.2

comment:20 Changed 9 years ago by Jean-Pierre Flori

Branch: u/jpflori/ticket/14605
Commit: 9d2673f4226a99868a8aa826d24b4f40ca15a089
Description: modified (diff)
Keywords: threads removed
Status: needs_workneeds_review
Summary: Fix thread related ATLAS problemsBetter system detection for ATLAS
Work issues: rebase

New commits:

9d2673fBetter system detection for ATLAS.

comment:21 Changed 9 years ago by git

Commit: 9d2673f4226a99868a8aa826d24b4f40ca15a0893f1defbe9f2e4affd39fa64673341039267900c1

Branch pushed to git repo; I updated commit sha1. New commits:

72e6977Merge remote-tracking branch 'trac/develop' into ticket/14605
3f1defbFix autotools optional spkg checksum spurious change.

comment:22 Changed 9 years ago by Volker Braun

Keywords: days57 added
Reviewers: Volker Braun

comment:23 Changed 9 years ago by Volker Braun

Status: needs_reviewpositive_review

lgtm

comment:24 Changed 9 years ago by Volker Braun

Branch: u/jpflori/ticket/146053f1defbe9f2e4affd39fa64673341039267900c1
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.