Opened 9 years ago

Closed 9 years ago

#14587 closed defect (fixed)

Gröbner bases via Macaulay2 broken

Reported by: Martin Albrecht Owned by: William Stein
Priority: major Milestone: sage-5.10
Component: interfaces Keywords:
Cc: wstein Merged in: sage-5.10.rc0
Authors: Martin Albrecht Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by Dima Pasechnik)

this shouldn't happen:

P.<a,b,c> = PolynomialRing(ZZ,3)
I = sage.rings.ideal.Katsura(P,3) # regenerate to prevent caching
I.groebner_basis('macaulay2:gb') # optional - macaulay2
TypeError: _groebner_basis_macaulay2() got an unexpected keyword argument 'prot'

Apply

Attachments (2)

trac_14587_m2.patch (1.1 KB) - added by Martin Albrecht 9 years ago.
trac_14587_doctests.patch (3.9 KB) - added by Volker Braun 9 years ago.
Initial patch

Download all attachments as: .zip

Change History (10)

Changed 9 years ago by Martin Albrecht

Attachment: trac_14587_m2.patch added

comment:1 Changed 9 years ago by Volker Braun

Description: modified (diff)
Reviewers: Volker Braun

I can confirm that the fix works (with Macaulay2 installed from Fedora).

There are some failing doctests, for example

sage -t sage/rings/polynomial/polynomial_ring.py
**********************************************************************
File "sage/rings/polynomial/polynomial_ring.py", line 693, in sage.rings.polynomial.polynomial_ring.PolynomialRing_general._macaulay2_
Failed example:
    macaulay2(R) # optional - macaulay2
Expected:
    QQ [x]
Got:
    QQ[x, Degrees => {1}, Heft => {1}, MonomialOrder => {MonomialSize => 32}, DegreeRank => 1]
                                                        {GRevLex => {1}    }
                                                        {Position => Up    }
**********************************************************************
1 item had failures:
   1 of   3 in sage.rings.polynomial.polynomial_ring.PolynomialRing_general._macaulay2_
    [319 tests, 1 failure, 2.01 s]

Can you clean those up, too?

comment:2 Changed 9 years ago by Martin Albrecht

I cannot test the fixes (Debian doesn't have M2). I can address that one, but it's probably quicker if you or someone with M2 fixes them?

Changed 9 years ago by Volker Braun

Attachment: trac_14587_doctests.patch added

Initial patch

comment:3 Changed 9 years ago by Volker Braun

Status: newneeds_review

Ok, done. Positive review to your half of the patch...

comment:4 Changed 9 years ago by Dima Pasechnik

Status: needs_reviewpositive_review

works on Sage 5.9 with system-wide M2 1.6 (OSX 10.6.8)

sage -bt --optional=sage,macaulay2 --long sage/rings/
...
All tests passed!
----------------------------------------------------------------------
Total time for all tests: 862.0 seconds
    cpu time: 774.6 seconds
    cumulative wall time: 828.1 seconds

comment:5 Changed 9 years ago by Jeroen Demeyer

Status: positive_reviewneeds_info

Which patch(es) should be applied?

comment:6 Changed 9 years ago by Dima Pasechnik

Description: modified (diff)
Status: needs_infoneeds_review

comment:7 Changed 9 years ago by Dima Pasechnik

Status: needs_reviewpositive_review

comment:8 Changed 9 years ago by Jeroen Demeyer

Merged in: sage-5.10.rc0
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.