Opened 8 years ago
Closed 8 years ago
#14573 closed enhancement (fixed)
Implement path realization for affine crystals
Reported by: | tscrim | Owned by: | sage-combinat |
---|---|---|---|
Priority: | major | Milestone: | sage-5.12 |
Component: | combinatorics | Keywords: | affine crystals, days49 |
Cc: | sage-combinat, bsalisbury1, aschilling | Merged in: | sage-5.12.beta1 |
Authors: | Travis Scrimshaw | Reviewers: | Ben Salisbury, Anne Schilling |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | #14402 | Stopgaps: |
Description
Attachments (1)
Change History (15)
comment:1 follow-up: ↓ 2 Changed 8 years ago by
- Status changed from new to needs_review
comment:2 in reply to: ↑ 1 Changed 8 years ago by
comment:3 Changed 8 years ago by
- Status changed from needs_review to needs_work
comment:4 Changed 8 years ago by
- Dependencies changed from #14402 #14516 to #14402
- Status changed from needs_work to needs_review
Hey Anne,
New version of the patch which does not depend on #14516 and addresses what we discussed.
Best,
Travis
comment:5 Changed 8 years ago by
New version with changes from Ben.
comment:6 Changed 8 years ago by
- Keywords days49 added
- Reviewers set to Ben Salisbury
- Status changed from needs_review to positive_review
comment:7 follow-up: ↓ 8 Changed 8 years ago by
- Reviewers changed from Ben Salisbury to Ben Salisbury, Anne Schilling
- Status changed from positive_review to needs_work
comment:8 in reply to: ↑ 7 Changed 8 years ago by
Hi Travis,
I have some further comments:
- The commit message is the merge of two patches; you might want to edit it!
- There is a typo "canonial" -> canonical
- Please explain what you mean by the bar on the weights. Also it would be a good idea to mention that
\Lambda_i
are the fundamental weights.
- Please mention that you are using the anti-Kashiwara convention for tensor factors (since I think your documentation differs in this from some of the literature and this might be confusing to users).
- Perhaps use capital
N
also in the equation before the sentence "We note by Lemma 10.6.2 in [HK02] ....".
- The documentation says B is a list of perfect crystals. But as far as I can see, in the examples the input is a single crystal. Could you please clarify? As I told Travis at some point in person, I think it would be a good idea to allow a list of crystals of the same level. If [B1,B2,....,Bk] would be such a list, one would use
\cdots \otimes B_1 \otimes B_2 \otimes \cdots B_k \otimes B_1 \otimes \cdots B_k \otimes B(\lambda)
as the model for the affine highest weight crystal.
- Could you add the affine grading? This would be useful since it is equal to the energy function!
Thank you,
Anne
comment:9 follow-up: ↓ 10 Changed 8 years ago by
- Status changed from needs_work to needs_review
All are done. I added an example showing it works with multiple crystals, and affine grading is inherited from the TensorProductOfCrystalsElement
.
comment:10 in reply to: ↑ 9 Changed 8 years ago by
Hi Travis and Ben,
I just discussed with Travis and he needs to change three more things:
- \mathfrankg needs to be fixed
- Please add the definition of \bar{\Lambda}
- For the input B can be a single crystal or a list of crystals.
Ben, Travis will make these changes tomorrow and once he has done it, you can set it to positive review.
Anne
Changed 8 years ago by
comment:11 Changed 8 years ago by
Fixed and ready for a final review.
comment:12 Changed 8 years ago by
- Status changed from needs_review to positive_review
comment:13 Changed 8 years ago by
- Milestone changed from sage-5.11 to sage-5.12
comment:14 Changed 8 years ago by
- Merged in set to sage-5.12.beta1
- Resolution set to fixed
- Status changed from positive_review to closed
Hi Travis,
The name of the class is not good. I would rather name such a class KyotoPathModel?. Also, there are several things stated wrong in the documentation. In addition, several methods do not explain their input. And why only input one B crystal? This model works in much greater generality.
It might be good if you could talk to people first to see what the needs are and what the best way to implement them are.
Best wishes,
Anne